Skip to content

Move requires_record_count to class instance#1385

Merged
lgebhardt merged 1 commit intorelease-0-10from
paginator_instance_controls_record_count
Mar 9, 2022
Merged

Move requires_record_count to class instance#1385
lgebhardt merged 1 commit intorelease-0-10from
paginator_instance_controls_record_count

Conversation

@lgebhardt
Copy link
Copy Markdown
Contributor

@lgebhardt lgebhardt commented Mar 9, 2022

Will fallback to deprecated class method for custom paginators derived from JSONAPI::Paginator

This will allow for custom paginators to optionally run record count queries based on pagination parameters in the request. Some count queries are expensive and are not required for all client uses.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

Will fallback to deprecated class method for custom paginators derived from JSONAPI::Paginator
@lgebhardt lgebhardt requested a review from dgeb March 9, 2022 13:50
@lgebhardt lgebhardt merged commit ae0c690 into release-0-10 Mar 9, 2022
@lgebhardt lgebhardt deleted the paginator_instance_controls_record_count branch March 9, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants