Skip to content

Allow processors to override global top_level_meta settings#1384

Merged
lgebhardt merged 1 commit intorelease-0-10from
override_default_meta_includes_v0_10
Mar 3, 2022
Merged

Allow processors to override global top_level_meta settings#1384
lgebhardt merged 1 commit intorelease-0-10from
override_default_meta_includes_v0_10

Conversation

@lgebhardt
Copy link
Copy Markdown
Contributor

@lgebhardt lgebhardt commented Mar 3, 2022

This set of changes allow a custom processor to override the defaults for top_level_meta_include_record_count and top_level_meta_include_page_count. The use case for this is to allow a custom paginator that does not require record_counts while still using default top_level_meta_include_* for most resource types.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@lgebhardt lgebhardt requested a review from dgeb March 3, 2022 16:36
@lgebhardt lgebhardt merged commit e2a7d6e into release-0-10 Mar 3, 2022
@lgebhardt lgebhardt deleted the override_default_meta_includes_v0_10 branch March 3, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants