Skip to content

Ensure eql? comparison object is the type expected#1368

Merged
lgebhardt merged 1 commit intorelease-0-10from
fix_path_segment_eql
May 19, 2021
Merged

Ensure eql? comparison object is the type expected#1368
lgebhardt merged 1 commit intorelease-0-10from
fix_path_segment_eql

Conversation

@lgebhardt
Copy link
Copy Markdown
Contributor

@lgebhardt lgebhardt commented May 19, 2021

This fixes a bug exposed by flappy tests on ruby 2.7.2 and 3.0. I still need to resolve the root cause of why strings are being passed in sometimes.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@lgebhardt lgebhardt requested a review from dgeb May 19, 2021 20:27
@lgebhardt lgebhardt merged commit 2c853dd into release-0-10 May 19, 2021
@lgebhardt lgebhardt deleted the fix_path_segment_eql branch May 19, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants