Skip to content

Fix sql quoting 0.10#1367

Merged
lgebhardt merged 1 commit intorelease-0-10from
fix_sql_quoting_0_10
May 19, 2021
Merged

Fix sql quoting 0.10#1367
lgebhardt merged 1 commit intorelease-0-10from
fix_sql_quoting_0_10

Conversation

@lgebhardt
Copy link
Copy Markdown
Contributor

  • Add quoting for fields in built up sql

  • Remove tests for generated sql statements

These are changing with new rails versions and it's creating a lot of false failures

  • Remove tests for generated sql statements using joins_left

  • Fix default sort for when empty array is provided

Fixes issue with relationship requests not getting a default sort

  • Add helper methods for generating sql fields with aliases and quotes

(cherry picked from commit 695bb7c)

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

…rated SQL strings

* Refine when config.active_record.sqlite3.represent_boolean_as_integer is set

* Add quoting for fields in built up sql

* Remove tests for generated sql statements

These are changing with new rails versions and it's creating a lot of false failures

* Remove tests for generated sql statements using joins_left

* Fix default sort for when empty array is provided

Fixes issue with relationship requests not getting a default sort

* Add helper methods for generating sql fields with aliases and quotes

(cherry picked from commit 695bb7c)
@lgebhardt
Copy link
Copy Markdown
Contributor Author

Tests are still flappy, though they can all complete with these changes.

@lgebhardt lgebhardt requested a review from dgeb May 19, 2021 17:10
@lgebhardt lgebhardt merged commit 49d213d into release-0-10 May 19, 2021
@lgebhardt lgebhardt deleted the fix_sql_quoting_0_10 branch May 19, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants