Skip to content

rails 6.1 supporting#1346

Merged
lgebhardt merged 1 commit intoJSONAPI-Resources:release-0-9from
gigorok:rails-6-1
Jan 18, 2021
Merged

rails 6.1 supporting#1346
lgebhardt merged 1 commit intoJSONAPI-Resources:release-0-9from
gigorok:rails-6-1

Conversation

@gigorok
Copy link
Copy Markdown
Contributor

@gigorok gigorok commented Dec 16, 2020 •
edited
Loading

closes #1343

related rails commits:
rails/rails@b0cc7d9
rails/rails@b30a23f

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@gigorok gigorok changed the base branch from master to release-0-9 December 16, 2020 08:07
@gigorok gigorok force-pushed the rails-6-1 branch 2 times, most recently from 72bc1ff to d9f77e0 Compare December 16, 2020 11:41
@gigorok gigorok marked this pull request as ready for review December 16, 2020 13:33
marcelolx
marcelolx approved these changes Dec 21, 2020
View reviewed changes
Copy link
Copy Markdown

@marcelolx marcelolx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@marcelolx
Copy link
Copy Markdown

marcelolx commented Dec 21, 2020

@lgebhardt Could you take a look on this?

@rsmithlal
Copy link
Copy Markdown

rsmithlal commented Jan 3, 2021

How are things going with this PR? I just ran into this issue reported in #1343 today while trying to upgrade my engine using jsonapi-resources to 6.1. Do you need a hand with something? If I can help move this issue along and get a new release version published, please let me know.

bf4
bf4 reviewed Jan 4, 2021
View reviewed changes
bf4
bf4 reviewed Jan 4, 2021
View reviewed changes
test/fixtures/active_record.rb
has_many :comments
has_and_belongs_to_many :tags, join_table: :posts_tags
has_many :special_post_tags, source: :tag
has_many :special_post_tags
Copy link
Copy Markdown
Collaborator

@bf4 bf4 Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this failing on 6.1?

Copy link
Copy Markdown
Contributor Author

@gigorok gigorok Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. because of rails/rails@b30a23f

bf4
bf4 reviewed Jan 4, 2021
View reviewed changes
@rsmithlal rsmithlal mentioned this pull request Jan 5, 2021
Closed
@nadnoslen
Copy link
Copy Markdown

nadnoslen commented Jan 16, 2021

Hey @bf4 & @lgebhardt & @marcelolx!

Hope you guys are well. Thanks again for all your work on this project.

I was looking at this PR the other day. This appears to be the bare minimum to permit Rails-6.1 compliance for the 0.9 version stream. Any hope that we get this blessed and released in the coming days?

Thanks for putting this PR together @gigorok

@lgebhardt lgebhardt merged commit ad64f14 into JSONAPI-Resources:release-0-9 Jan 18, 2021
lgebhardt pushed a commit that referenced this pull request Jan 19, 2021
@gigorok @lgebhardt
rails v6.1 compatibility (#1346)
889005e
@lgebhardt lgebhardt mentioned this pull request Jan 19, 2021
Merged
12 tasks
lgebhardt added a commit that referenced this pull request Jan 20, 2021
@lgebhardt @gigorok
Rails 6.1 (#1352)
1322b59 
* Rails v6.1 compatibility (#1346)

* Fixes for rails 6.1.1

* Fixes for ruby 3.0.0

* Remove rails 5.0 support

Co-authored-by: Igor Gonchar <[email protected]>
@qrush
Copy link
Copy Markdown

qrush commented Jan 25, 2021

Checking in here as I'm upgrading an app to Rails 6.1 - is there any chance a gem could be cut for 0.9.x? 🙏

@marcelolx marcelolx mentioned this pull request Jan 28, 2021
Closed
@CodingItWrong CodingItWrong mentioned this pull request Jan 28, 2021
Closed
7 tasks
lgebhardt added a commit that referenced this pull request Feb 4, 2021
@lgebhardt
Rails 6.1 (#1352)
1533cc8 
* Rails v6.1 compatibility (#1346)

* Fixes for rails 6.1.1

* Fixes for ruby 3.0.0

* Remove rails 5.0 support

Co-authored-by: Igor Gonchar <[email protected]>

(cherry picked from commit 1322b59)
lgebhardt added a commit that referenced this pull request Feb 4, 2021
@lgebhardt
Support Rails 6.1
7e9fd44 
* Setup github actions for CI

(cherry picked from commit e894827)

* Rails 6.1 (#1352)

* Rails v6.1 compatibility (#1346)

* Fixes for rails 6.1.1

* Fixes for ruby 3.0.0

* Remove rails 5.0 support

Co-authored-by: Igor Gonchar <[email protected]>

(cherry picked from commit 1322b59)
@RKushnir RKushnir mentioned this pull request Feb 23, 2021
Merged
@tramuntanal tramuntanal mentioned this pull request Sep 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgebhardt lgebhardt lgebhardt left review comments

@bf4 bf4 bf4 left review comments

+1 more reviewer

@marcelolx marcelolx marcelolx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gigorok @marcelolx @rsmithlal @nadnoslen @qrush @lgebhardt @bf4