Migrate Source.Python CS:GO Entity Logic to Source 2 VScript #1
Conversation
- Analyze legacy `csgo.py` logic for weapon creation/finding. - Create `cs_weapon_factory.lua` for Source 2. - Prioritize native `Entities:CreateByClassname` over legacy workarounds. - Document limitations regarding NetProp access in VScript.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Migrated the CS:GO entity creation/finding logic from Source.Python (Source 1) to a native Source 2 VScript (Lua) module.
The original logic handled legacy quirks where specific weapons (e.g., Silenced M4) had to be spawned as parent classes with modified Item Definition Indices. In Source 2, these are largely native entities.
The new
cs_weapon_factory.luaprioritizes native creation (Entities:CreateByClassname) and removes the potentially harmful fallback logic that relied on unavailable NetProp writing APIs.Risk: Low. This is a new file and does not affect existing Source 1 code.
Changes:
cs_weapon_factory.luaPR created automatically by Jules for task 4844138009885378033 started by @JMorell