Conversation
- Modify `UpdateAndGetAXSharpConfig` method in `AXSharpConfig` to include `ICompilerOptions dependnantCompilerOptions` parameter. - Update `AXSharpProject` constructor to accept `ICompilerOptions? dependnantCompilerOptions` and pass it to `UpdateAndGetAXSharpConfig`. - Add check in `AXSharpProject` to ensure `TargetPlatfromMoniker` is set in `AXSharp.config.json`, throwing an exception if not. - Update `IecToClrConverter`'s `CreateScalarInitializer` to throw `ArgumentNullException` if `targetPlatformMoniker` is null. - Refactor `GenerateIxProject` method in `Program` class to use `options` as a more descriptive parameter name. - Correct `workingDirectory` path in `launchSettings.json` for `axopen-traversal` profile.
Added a check in AXSharpProject.cs for the TargetPlatfromMoniker property of CompilerOptions, setting a default value of "ax" and logging a warning if it is null. Updated IxProjectTests.cs to include a new using directive for AXSharp.CompilerTests and modified the AXSharpProject constructor call to include two instances of CompilerTestOptions. Added a new file, CompilerTestOptions.cs, defining the CompilerTestOptions class with default values and basic getter and setter implementations.
PTKu
deleted the
370-when-compiling-dependencies-of-larger-project-the-tpf-is-null
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the AXSharp compiler, focusing on adding support for dependent compiler options and improving project handling. The most important changes include updates to the
AXSharpConfigandAXSharpProjectclasses, as well as adjustments to test files to accommodate the new functionality.Updates to AXSharpConfig and AXSharpProject:
src/AXSharp.compiler/src/AXSharp.Compiler/AXSharpConfig.cs: Added a new parameterdependnantCompilerOptionsto theUpdateAndGetAXSharpConfigmethod to support dependent compiler options.src/AXSharp.compiler/src/AXSharp.Compiler/AXSharpConfig.cs: Updated the method to applyTargetPlatfromMonikerfromdependnantCompilerOptionsif provided.src/AXSharp.compiler/src/AXSharp.Compiler/AXSharpProject.cs: Added a new parameterdependnantCompilerOptionsto theAXSharpProjectconstructor to support dependent compiler options.src/AXSharp.compiler/src/AXSharp.Compiler/AXSharpProject.cs: ModifiedCompileProjectReferencesto passdependnantCompilerOptionsand set a defaultTargetPlatfromMonikerif not specified.Adjustments to test files:
src/AXSharp.compiler/tests/AXSharp.CompilerTests/CompilerTestOptions.cs: Added a new classCompilerTestOptionsimplementingICompilerOptionsfor testing purposes.src/AXSharp.compiler/tests/AXSharp.CompilerTests/IxProjectTests.cs: Updated test caseshould_generate_output_of_ix_projectto use the newCompilerTestOptionsclass.closes #370