Conversation
Replaced custom leap year adjustments with UTC-based methods: - In `WebApiDate.cs`, replaced `AdjustForLeapDate` with `GetDateOnly`. - In `WebApiDateTime.cs`, replaced `AdjustForLeapDateTime` with `ToUtcDateTime`. - In `WebApiLDate.cs`, replaced `AdjustForLeapDate` with `GetDateOnly`. - In `WebApiLDateTime.cs`, replaced `AdjustForLeapDateTime` with `ToUtcDateTime`. - In `WebApiConnectorExtensions.cs`, removed `AdjustForLeapDate` and `AdjustForLeapDateTime`, added `GetDateOnly` and `ToUtcDateTime`. Updated tests: - In `WebApiPrimitiveTests.cs`, updated leap year test dates and uncommented assertion. Added new Visual Studio solution file: - `ax-test-project.sln` for `ax_test_project` with Debug and Release configurations.
PTKu
deleted the
203-bug-days-in-leap-year-are-not-correctly-retrieved-from-the-controller
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
AXSharp.Connector.S71500.WebAPIproject, primarily focused on updating date and time handling methods and improving test coverage.Date and Time Handling Updates:
src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/BuiltInWrappers/WebApiDate.cs: ReplacedAdjustForLeapDatewithGetDateOnlyin theGetFromBinarymethod.src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/BuiltInWrappers/WebApiDateTime.cs: ReplacedAdjustForLeapDateTimewithToUtcDateTimein theGetFromBinarymethod.src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/BuiltInWrappers/WebApiLDate.cs: ReplacedAdjustForLeapDatewithGetDateOnlyin theGetFromBinarymethod.src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/BuiltInWrappers/WebApiLDateTime.cs: ReplacedAdjustForLeapDateTimewithToUtcDateTimein theGetFromBinarymethod.src/AXSharp.connectors/src/AXSharp.Connector.S71500.WebAPI/WebApiConnectorExtensions.cs: UpdatedAdjustForLeapDatetoGetDateOnlyandAdjustForLeapDateTimetoToUtcDateTime.Test Coverage Improvements:
src/AXSharp.connectors/tests/AXSharp.Connector.Sax.WebAPITests/WebApiConnector/WebApiPrimitiveTests.cs: Modified the leap year test to increase the test range and added an assertion for validation.Project Configuration:
src/AXSharp.connectors/tests/ax-test-project/ax-test-project.sln: Added a new Visual Studio solution file for theax_test_project.closes [BUG] Days in leap year are not correctly retrieved from the controller #203