[pull] main from angular:main#516
Merged
Merged
Conversation
Currently, signal migration schematics in best effort mode doesn't do a very good job migrating input writes when there is a nested property access in templates. In event handlers, no attempt is made to migrate a nested access in the left-hand-side of assignments or anything in their right-hand-side. E.g., nothing will happen here: `(ngModelChange)="inputD.prop = $event + inputF"`. Additionally, when a migration attempt is made, parentheses are often incorrectly placed on the parent, both in event handlers and two-way bindings: `(ngModelChange)="inputC = $event"` is migrated to `(ngModelChange)="inputC = $event()"`. `[(ngModel)]="inputB.prop.prop"` is migrated to `[(ngModel)]="inputB.prop().prop"`.
The Aria menubar examples render each menu in a `cdkConnectedOverlay`, which detaches the top-most overlay on every Escape keypress (`disableClose` defaults to `false`). The top-level menus are always attached, so a detached overlay never reattaches and its `viewChild` reference becomes `undefined`. Holding Escape detaches the overlays one by one, permanently breaking menus such as "Insert" and "Format". Set `cdkConnectedOverlayDisableClose` on the example overlays so the menu pattern remains the single owner of open/close state, matching the combobox and toolbar examples. Applied to the basic, disabled, and rtl menubar examples (and their material/retro variants).
Update and streamline the Model Context Protocol (MCP) server setup guide. This includes revising tool descriptions, replacing multiple experimental tools with a single target runner option, updating configurations for supported IDEs, and removing obsolete setup sections.
See associated pull request for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )