You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Changes how signing conformance is validated in CI and ties releases to an external spec repo/branch fallback, but does not alter runtime signing logic in the SDK.
Overview Signing golden tests now read fixtures from INTENTPROOF_SPEC_DIR/golden/sdk-signing when that env var is set, and otherwise keep using tests/fixtures for local runs.
CI checks out IntentProof/intentproof-spec, falls back to phase3-ecosystem-conformance if golden/sdk-signing is missing on main, runs coverage with INTENTPROOF_SPEC_DIR, and adds a sync gate that fails when mirrored signing_* files under tests/fixtures differ from the spec golden copies.
Reviewed by Cursor Bugbot for commit bf59b99. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INTENTPROOF_SPEC_DIR/golden/sdk-signingin signing golden tests.Phase 3 drift D.9. Requires spec #100 on
mainfor CI green.Test plan
python3 -m pytestbash scripts/run-coverage-gate.sh