Fix UnboundLocalError in RepNCSPELAN4 when csp_type != 'csp2'#55
Open
cxnt wants to merge 1 commit intoIntellindust-AI-Lab:mainfrom
Open
Fix UnboundLocalError in RepNCSPELAN4 when csp_type != 'csp2'#55cxnt wants to merge 1 commit intoIntellindust-AI-Lab:mainfrom
cxnt wants to merge 1 commit intoIntellindust-AI-Lab:mainfrom
Conversation
## Description
This PR fixes an `UnboundLocalError` in the `RepNCSPELAN4` class that occurs when `csp_type` parameter is set to any value other than `'csp2'`.
## Problem
The current implementation in `hybrid_encoder.py` has a conditional assignment issue:
```python
if csp_type == 'csp2':
CSPLayer = CSPLayer2
self.cv2 = nn.Sequential(CSPLayer(...), ...) # CSPLayer used here
```
When `csp_type != 'csp2'`, the local variable `CSPLayer` is never assigned, but Python still treats it as a local variable due to the assignment in the `if` block. This prevents falling back to the global `CSPLayer` class and raises:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an
UnboundLocalErrorin theRepNCSPELAN4class that occurs whencsp_typeparameter is set to any value other than'csp2'.Problem
The current implementation in
hybrid_encoder.pyhas a conditional assignment issue:When
csp_type != 'csp2', the local variableCSPLayeris never assigned, but Python still treats it as a local variable due to the assignment in theifblock. This prevents falling back to the globalCSPLayerclass and raises: