Merged
Conversation
facebook-github-bot
added
the
CLA Signed
zsol
reviewed
Mar 13, 2025
| # Install build-system.requires dependencies | ||
| pip install setuptools setuptools-scm setuptools-rust wheel | ||
| # Jupyter is annoying to install on free-threaded Python | ||
| pip install -e .[dev-without-jupyter] --no-build-isolation |
Contributor
There was a problem hiding this comment.
oh i just noticed this, would CI still work without --no-build-isolation?
ngoldbaum
added a commit
to ngoldbaum/LibCST
that referenced
this pull request
Apr 8, 2025
jorenham
pushed a commit
to jorenham/LibCST
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref #1242
passes CI on my fork: https://github.com/ngoldbaum/LibCST/actions/runs/13817416645
Is adding
dev-without-jupyterinpyproject.tomlok? It seemed like the cleanest way to handle avoiding jupyter. You could also splitdevintotestsanddocsbut I'm not sure how to sort the dependencies.The windows 3.13t CI is pretty slow but I think most of that is just installing Python and once the cache populates it should be faster.
I'm pinning to an unreleased version of
setup-python- hopefully Github does a release with free-threaded support soon.