Add typing classifier to pyproject.toml and badge to README#1272
Merged
zsol merged 1 commit intoInstagram:mainfrom Jan 4, 2025
Merged
Add typing classifier to pyproject.toml and badge to README#1272zsol merged 1 commit intoInstagram:mainfrom
zsol merged 1 commit intoInstagram:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
zsol
approved these changes
Jan 3, 2025
Contributor
zsol
left a comment
zsol
left a comment
There was a problem hiding this comment.
This badge will say "untyped" until I make a new release on pypi, right? That's a bit unfortunate
Contributor
Author
|
I can split the tag & badge into separate PRs if you don't want that |
Contributor
|
I don't mind :) |
jorenham
pushed a commit
to jorenham/LibCST
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add typing :: types classifier so that the package will be eligible for https://shields.io/badges/py-pi-types
Add the badge to the README (until the package is released again it will show as untyped)
Test Plan
CI