Contain write operations within with statements#195
Merged
Conversation
Fixes open files issue
kccwing
reviewed
Jun 7, 2022
| self.fid_cond_num = open(dire + 'cond_num.dat', "w") | ||
|
|
||
| self.out_files = {'lambda': dire + 'lambda.dat', | ||
| 'lambda_dot': dire + 'lambda.dat', |
Collaborator
There was a problem hiding this comment.
... dire + 'lambda_dot.dat'
kccwing
reviewed
Jun 8, 2022
| for out_var, data in out_data.items(): | ||
| file_name = self.out_files[out_var] | ||
| with open(file_name, 'a') as fid: | ||
| fid.write(f'{self.data.ts:g} {iteration:g}') |
Collaborator
There was a problem hiding this comment.
fid.write(f'{self.data.ts:g} {iteration:g} ')
kccwing
reviewed
Jun 8, 2022
| fid.write(f'{self.data.ts:g} {iteration:g}') | ||
| for ilm in range(self.num_LM_eq): | ||
| fid.write(f'{data[ilm]} ') | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes open files issue. Probably not the most efficient implementation as the files are opened/closed at each FSI iteration but solves the issue of files being left open.
Also fixes a hardcoded directory