Skip to content

Update samples to illustrate artifact registry style urls.#4044

Closed
donmccasland wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
donmccasland:master
Closed

Update samples to illustrate artifact registry style urls.#4044
donmccasland wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
donmccasland:master

Conversation

@donmccasland

@donmccasland donmccasland commented Oct 20, 2020

Copy link
Copy Markdown
Member

Fixes #4042

Samples should now include examples of also using an artifact registry style url along with the container registry url.

Example:
Container Registry URL: gcr.io/my-project/my-repo/my-image
Artifact Registry URL: LOCATION-docker.pkg.dev/my-project/my-repo/my-image

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@donmccasland donmccasland requested a review from a team October 20, 2020 22:20
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 20, 2020
kurtisvg
kurtisvg previously approved these changes Oct 20, 2020
View reviewed changes
@kurtisvg kurtisvg changed the title #4042 update sample to illustrate AR style urls Update samples to illustrate artifact registry style urls. Oct 20, 2020
@kurtisvg

kurtisvg commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

There are some style issues with tabs/spaces blocking the lint check.

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Oct 21, 2020
lesv
lesv previously approved these changes Oct 21, 2020
View reviewed changes
@lesv

lesv commented Oct 21, 2020

Copy link
Copy Markdown
Contributor

Lint

@donmccasland Can you get rid of the tabs?

#
# container-registry/container-analysis
#

[ERROR] src/main/java/com/example/containeranalysis/VulnerabilityOccurrencesForImage.java:[33,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/VulnerabilityOccurrencesForImage.java:[34,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/VulnerabilityOccurrencesForImage.java:[35,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/VulnerabilityOccurrencesForImage.java:[35,9] (indentation) CommentsIndentation: Comment has incorrect indentation level 1, expected is 4, indentation should be the same level as line 37.
[ERROR] src/main/java/com/example/containeranalysis/CreateOccurrence.java:[36,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/CreateOccurrence.java:[37,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/CreateOccurrence.java:[38,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/CreateOccurrence.java:[38,9] (indentation) CommentsIndentation: Comment has incorrect indentation level 1, expected is 4, indentation should be the same level as line 42.
[ERROR] src/main/java/com/example/containeranalysis/PollDiscoveryOccurrenceFinished.java:[37,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/PollDiscoveryOccurrenceFinished.java:[38,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/PollDiscoveryOccurrenceFinished.java:[39,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/PollDiscoveryOccurrenceFinished.java:[39,9] (indentation) CommentsIndentation: Comment has incorrect indentation level 1, expected is 4, indentation should be the same level as line 42.
[ERROR] src/main/java/com/example/containeranalysis/HighVulnerabilitiesForImage.java:[34,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/HighVulnerabilitiesForImage.java:[35,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/HighVulnerabilitiesForImage.java:[36,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/HighVulnerabilitiesForImage.java:[36,9] (indentation) CommentsIndentation: Comment has incorrect indentation level 1, expected is 4, indentation should be the same level as line 38.
[ERROR] src/main/java/com/example/containeranalysis/OccurrencesForImage.java:[33,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/OccurrencesForImage.java:[34,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/OccurrencesForImage.java:[35,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/OccurrencesForImage.java:[35,9] (indentation) CommentsIndentation: Comment has incorrect indentation level 1, expected is 4, indentation should be the same level as line 37.
[ERROR] src/main/java/com/example/containeranalysis/GetDiscoveryInfo.java:[33,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/GetDiscoveryInfo.java:[34,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/GetDiscoveryInfo.java:[35,1] (whitespace) FileTabCharacter: Line contains a tab character.
[ERROR] src/main/java/com/example/containeranalysis/GetDiscoveryInfo.java:[35,9] (indentation) CommentsIndentation: Comment has incorrect indentation level 1, expected is 4, indentation should be the same level as line 37.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check (default-cli) on project containeranalysis: You have 24 Checkstyle violations. -> [Help 1]

@lesv lesv added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 22, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2020
@lesv lesv removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 22, 2020
@lesv lesv dismissed stale reviews from kurtisvg and themself October 22, 2020 19:12

lets rereview after lint passes

@lesv lesv added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 22, 2020
@lesv lesv marked this pull request as draft October 29, 2020 18:47
@stale

stale Bot commented Dec 5, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale-wontfix label Dec 5, 2020
@stale stale Bot closed this Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lesv lesv lesv left review comments

@kurtisvg kurtisvg kurtisvg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kurtisvg kurtisvg

Labels

cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples. stale-wontfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update samples for Artifact Registry

4 participants

@donmccasland @kurtisvg @lesv @kokoro-team