fix: update libraries and python for the base image#570
Merged
Conversation
Contributor
Author
|
if tests pass replaces #552; I selected the versions of python and CLOUD_SDK_VERSION based on https://github.com/googleapis/google-cloud-python/blob/main/.kokoro/docker/docs/Dockerfile I suspect that this could be simplified a lot more because I think the base is building from https://github.com/googleapis/testing-infra-docker/blob/main/python/cloud-devrel-kokoro-resources/python-base/Dockerfile |
Contributor
Author
|
#571 needs to happen first so that nox doesn't get complaints about old version of python not being supported. |
davidcavazos
approved these changes
Aug 22, 2024
| ENV CLOUD_SDK_VERSION 489.0.0 | ||
| # Use system python for cloud sdk. | ||
| ENV CLOUDSDK_PYTHON /usr/bin/python | ||
| ENV CLOUDSDK_PYTHON python3.12 |
There was a problem hiding this comment.
Should we use something like ENV CLOUDSDK_PYTHON $(which python3)? (Not sure if that's valid Docker)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pulled a selection from the testing infra docs. nox probably needs to pull a latest as well.