Skip to content

chore: Pre-release version 2.4.0-beta.2#164

Merged
KaylaNguyen merged 4 commits into
GoogleCloudPlatform:masterfrom
KaylaNguyen:version-v2.4.0-beta.2
Nov 1, 2021
Merged

chore: Pre-release version 2.4.0-beta.2#164
KaylaNguyen merged 4 commits into
GoogleCloudPlatform:masterfrom
KaylaNguyen:version-v2.4.0-beta.2

Conversation

@KaylaNguyen

Copy link
Copy Markdown
Contributor

No description provided.

@google-cla google-cla Bot added the cla: yes label Oct 30, 2021
@KaylaNguyen KaylaNguyen requested a review from grant October 30, 2021 01:31
@KaylaNguyen KaylaNguyen requested a review from anniefu November 1, 2021 21:27

@grant grant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I'm unsure if we want to delete the beta.1 release
  • nit: I believe these commits should be in the type chore, as in chore: Pre-release version 2.4.0-beta.2 as to not produce a change in semver.

Comment thread CHANGELOG.md
Comment thread CHANGELOG.md
@KaylaNguyen KaylaNguyen changed the title feat: Pre-release version 2.4.0-beta.2 chore: Pre-release version 2.4.0-beta.2 Nov 1, 2021
@KaylaNguyen KaylaNguyen requested a review from grant November 1, 2021 22:15

@grant grant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@KaylaNguyen KaylaNguyen merged commit 75cc22c into GoogleCloudPlatform:master Nov 1, 2021
KaylaNguyen added a commit to KaylaNguyen/functions-framework-python that referenced this pull request Nov 2, 2021
@KaylaNguyen KaylaNguyen deleted the version-v2.4.0-beta.2 branch November 12, 2021 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants