Fix management of the ApiProxy.Environment for DevAppServer#437
Merged
copybara-service[bot] merged 2 commits intomainfrom Nov 28, 2025
Merged
Fix management of the ApiProxy.Environment for DevAppServer#437copybara-service[bot] merged 2 commits intomainfrom
copybara-service[bot] merged 2 commits intomainfrom
Conversation
ludoch
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to close #426 by ensuring the
LocalEnvironmentis created by the time theApiProxy.Environmentthread local is set inside the context scope listener.I tested this manually against a reproduction case of this bug but I don't believe there are many junit tests for the
DevAppServer. To reproduce this bug you must override the_ah_ResponseRewriterFilterin web.xml otherwise this will commit the response itself, then you must hit a servlet which modifies the session but does not commit the response.