docs: correct the Node.js version base#13099
docs: correct the Node.js version base#13099devtools-bot merged 2 commits intoGoogleChrome:masterfrom
Conversation
The PR#13045 converts cli to use esm which also uses named exports for commonjs, this commit just corrects the description in README.
|
See https://twitter.com/MylesBorins/status/1311033983824793601, this is a tweet about named imports from CJS. |
|
12.13 (as defined in our package.json) does indeed error.
Can you change the version here + in package.json to be |
@connorjclark, thanks for your reply, and it seems here to be 12.20.0 because the named imports are not supported yet at 12.17.0, and I also reproduce the issue at this version at my MBP, and it gets fixed when I used 12.20.0. BTW the correct versions are >= 12.20 for Node12 and >=14.13 for Node14 via nodejs/node#35249, do you have any suggestion? |
|
ah ok, let's list the minimum versions for 12 as 12.20 and 14 as 14.13 in the readme then. (and 12.20 for package.json) I tried different variations of compound version checks in the EDIT: actually |
|
@connorjclark Updated. |
|
@connorjclark May I ask you to have a look? |
|
ในวันที่ ส. 2 ต.ค. 2021 07:16 น. devtools-bot ***@***.***>
เขียนว่า:
… Merged #13099 <#13099>
into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#13099 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APZGLUQUPIIRKMYLJNVMID3UEZFMRANCNFSM5ERUHQUA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
ในวันที่ ส. 2 ต.ค. 2021 07:11 น. Paul Irish ***@***.***>
เขียนว่า:
… ***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#13099 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APZGLUSUYKICO5NPZIBEGILUEZEZHANCNFSM5ERUHQUA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Summary
The PR(#13045) converts cli to use esm which also uses named exports for commonjs, this commit just corrects the description in README.
Related Issues/PRs