[WIP] Consolidate error handling at layout level #5568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
simeonlee
changed the title
7 tasks
simeonlee
force-pushed
the
simeonlee/global-error-boundary
branch
from
7d95d7a to
e0fe1c5
Compare
simeonlee
force-pushed
the
simeonlee/route-error-boundaries
branch
2 times, most recently
from
ecee654 to
9fd23fd
Compare
Each top-level layout now has an ErrorBoundary that catches errors from child routes and displays them using RouteErrorContent. This provides consistent error handling at the page level while keeping the sidebar visible.
Now that layouts have ErrorBoundary, individual routes no longer need their own error handling. Errors bubble up to the nearest layout. Removes ~700 lines of duplicated error handling code.
simeonlee
force-pushed
the
simeonlee/route-error-boundaries
branch
from
9fd23fd to
f6def3e
Compare
- Add vertical-stacking SimpleErrorDisplay for header-only errors - Use FileQuestion icon with muted styling for 404s
simeonlee
force-pushed
the
simeonlee/route-error-boundaries
branch
from
a8e1d5f to
2f5b49f
Compare
simeonlee
merged commit 90f7d7c
into
simeonlee/global-error-boundary
46 of 51 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RouteErrorContentResult: All page errors show light card (less scary), infra errors show dark modal (PR #5549).
Part of error boundary PR stack:
Rationale
Why layout-level instead of route-level?
Without this PR, errors would be caught by the root boundary and show a dark modal for everything. With layout-level boundaries:
The layout boundary intercepts page errors before they reach root, enabling the better UX.
Why not keep route-level boundaries?
/playground)Approach
RouteErrorContent(light card)RouteErrorContent(light card)ErrorDialog(dark modal)Layouts Covered
Top-level layouts with ErrorBoundary added:
datasets/layout.tsxdatapoints/layout.tsxevaluations/layout.tsxworkflow_evaluations/layout.tsxautopilot/layout.tsxobservability/functions/layout.tsxobservability/inferences/layout.tsxobservability/episodes/layout.tsxLocal Testing
Create uncommitted debug routes:
/_debug/error-page/_debug/error-infraStatus
🚧 Work in progress - not ready for review
Test plan