Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
markAliasReferencedwe check that theSymbolFlagsof the resolved symbol includesSymbolFlags.Value. However, if the default export points to a variable that is also exported, and that variable merges with a type that is not, the alias we create when importing the default export points to the local symbol (which hasSymbolFlags.Interface | SymbolFlags.ExportValue) and not the export symbol (which hasSymbolFlags.Value).Since you can only end up with
SymbolFlags.ExportValueif the export symbol is a value, this change considers such a local symbol to also be a value for the purpose of marking the import alias as referenced.Fixes #47598