Use environment variables in GitHub workflows #8500
+78
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Currently we use the GitHub Actions expression syntax directly in the scripts, which means that bad input could break the workflows or result in extra code being run. This pull request switches to using environment variables instead, that way they can be read securely inside the scripts (quoted in shell scripts, using
strenv()inyqcommands and withprocess.envin theactions/github-scriptaction). Other changes include switching from using themikefarah/yqaction to using theyqbinary that is preinstalled on the GitHub Actions runner and using step outputs with explicitenv:declarations instead of $GITHUB_ENV.Desktop