Fix dropdownShown error on the watch page for live streams #8331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 23, 2025
ChunkyProgrammer
approved these changes
Nov 24, 2025
PikachuEXE
approved these changes
Nov 24, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 24, 2025
* development: (72 commits) Bump shaka-player from 4.16.9 to 4.16.10 (FreeTubeApp#8345) Bump the stylelint group with 2 updates (FreeTubeApp#8334) Bump the eslint group with 2 updates (FreeTubeApp#8333) Bump vue from 3.5.24 to 3.5.25 (FreeTubeApp#8336) Bump electron-builder from 26.2.0 to 26.3.0 (FreeTubeApp#8341) Bump marked from 17.0.0 to 17.0.1 (FreeTubeApp#8339) Bump webpack from 5.102.1 to 5.103.0 (FreeTubeApp#8340) Translated using Weblate (English (United Kingdom)) Bump html-webpack-plugin from 5.6.4 to 5.6.5 (FreeTubeApp#8342) Bump mikefarah/yq from 4.48.1 to 4.49.1 (FreeTubeApp#8343) Bump actions/checkout from 5 to 6 (FreeTubeApp#8344) Bump electron from 39.2.1 to 39.2.3 (FreeTubeApp#8337) Bump sass from 1.94.0 to 1.94.2 (FreeTubeApp#8335) Translated using Weblate (Dutch) Translated using Weblate (Chinese (Traditional Han script)) Fix dropdownShown error on the watch page for live streams (FreeTubeApp#8331) Fix view count with RSS feeds (FreeTubeApp#8328) Add support for exporting watch history in YouTube's JSON format (FreeTubeApp#8323) Cleanup leftover import toast (FreeTubeApp#8325) Translated using Weblate (Portuguese (Brazil)) ... # Conflicts: # package.json
rugabunda
pushed a commit
to rugabunda/FreeTube
that referenced
this pull request
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
TypeError: Cannot read properties of null (reading 'dropdownShown')#8330Description
This pull request fixes a bug introduced by the composition API migration of the WatchVideoInfo component, by checking if the download button actually exists before attaching a watcher to its dropdown.
Testing
Desktop