Bump electron from 38.4.0 to 39.2.1 #8303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot
bot
added
PR: dependencies
PikachuEXE
requested changes
Nov 17, 2025
Collaborator
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
electron/electron#48736 still up
Member
|
Yeah so im not sure if that is a valid issue or that they messed up something on their end because when i tested for this on v39 i didn't had this issue. I will retest again and if the issue doesn't surface than its probably safe to merge |
Member
|
electron/electron#48956 seems more problematic though |
Member
|
@PikachuEXE Unless we can reproduce it on our end, I think we can ignore that as the only thing it would break is that FreeTube wouldn't be able to follow the system dark and light mode, but users can still manually select their theme in the FreeTube settings. @efb4f5ff-1298-471a-8973-3d47447115dc That is already solved in this release, as they reverted the change that caused it, it is the first entry in the changelog. The reason the issue is still open is because they want to bring back the change but without the crash. |
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
Contributor
Author
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Nov 17, 2025
Member
|
cant repro the theming issues lets merge this |
Member
|
@dependabot recreate |
dependabot
bot
dismissed
efb4f5ff-1298-471a-8973-3d47447115dc’s stale review
via
5c3b963
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/electron-39.2.1
branch
from
57cfc56 to
5c3b963
Compare
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 17, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
ChunkyProgrammer,
PikachuEXE,
absidue and
kommunarr
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
absidue
approved these changes
Nov 17, 2025
Bumps [electron](https://github.com/electron/electron) from 38.4.0 to 39.2.1. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v38.4.0...v39.2.1) --- updated-dependencies: - dependency-name: electron dependency-version: 39.2.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/electron-39.2.1
branch
from
5c3b963 to
c720e29
Compare
ChunkyProgrammer
approved these changes
Nov 18, 2025
PikachuEXE
approved these changes
Nov 18, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 18, 2025
* development: (22 commits) Workaround ready-to-show not firing consistently on wayland (FreeTubeApp#8294) Bump electron from 38.4.0 to 39.2.1 (FreeTubeApp#8303) Migrate the WatchVideoInfo component to the composition API (FreeTubeApp#8295) Translated using Weblate (Hungarian) Translated using Weblate (Norwegian Bokmål) Translated using Weblate (French) Bump eslint-plugin-jsdoc from 61.1.12 to 61.2.1 in the eslint group (FreeTubeApp#8298) Replace broken trending with a local API only equivalent (FreeTubeApp#8289) Fix settings layout issues after the Vue 3 migration (FreeTubeApp#8292) Bump lefthook from 2.0.3 to 2.0.4 (FreeTubeApp#8299) Bump shaka-player from 4.16.8 to 4.16.9 (FreeTubeApp#8301) Bump electron-builder from 26.1.0 to 26.2.0 (FreeTubeApp#8302) Fix playlist video view counts on the local API (FreeTubeApp#8290) change hardcoded color app text logoColor (FreeTubeApp#8288) Translated using Weblate (Russian) Translated using Weblate (German) wrap long playlist strings (FreeTubeApp#8275) Translated using Weblate (Bulgarian) Bump js-yaml from 4.1.0 to 4.1.1 (FreeTubeApp#8284) bump workflows node-version to 24 (FreeTubeApp#8279) ... # Conflicts: # src/renderer/helpers/api/invidious.js
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 18, 2025
* development: Translated using Weblate (Chinese (Simplified Han script)) Workaround ready-to-show not firing consistently on wayland (FreeTubeApp#8294) Bump electron from 38.4.0 to 39.2.1 (FreeTubeApp#8303) Migrate the WatchVideoInfo component to the composition API (FreeTubeApp#8295) Translated using Weblate (Hungarian) Translated using Weblate (Norwegian Bokmål) Translated using Weblate (French) Bump eslint-plugin-jsdoc from 61.1.12 to 61.2.1 in the eslint group (FreeTubeApp#8298) Replace broken trending with a local API only equivalent (FreeTubeApp#8289) Fix settings layout issues after the Vue 3 migration (FreeTubeApp#8292) Bump lefthook from 2.0.3 to 2.0.4 (FreeTubeApp#8299) Bump shaka-player from 4.16.8 to 4.16.9 (FreeTubeApp#8301) Bump electron-builder from 26.1.0 to 26.2.0 (FreeTubeApp#8302) # Conflicts: # src/renderer/helpers/api/local.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps electron from 38.4.0 to 39.2.1.
Release notes
Sourced from electron's releases.
... (truncated)
Commits
d9c33a9build: add header for SetStackDumpFirstChanceCallback in renderer client (#48...8b02e33build: limit workflow gh token permissions (#48969)eecca2cfix: revert enabling WASM trap handlers in all Node.js processes (#48975)08b5ef5test: addview.getBounds|setBoundstests (#48961)ab85f2cchore: cherry-pick 4cf9311 from v8 (#48951)1936243fix: crash on windows when UTF-8 is in path (#48944)e7e052fdocs: fix docs forapp.isHardwareAccelerationEnabled()(#48945)349a9b6docs: explain how to load SF Symbols withnativeImage(#48939)b5f19cefeat: add bypassCustomProtocolHandlers option to net.request (#48882)bb930b8feat: addapp.isHardwareAccelerationEnabled()(#48680)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)