Skip to content

Fix event thread assignment in TeleportWarmupCancelledEvent#6371

Merged
JRoy merged 2 commits intoEssentialsX:2.xfrom
SrBedrock:dev/fix-async-event
Dec 2, 2025
Merged

Fix event thread assignment in TeleportWarmupCancelledEvent#6371
JRoy merged 2 commits intoEssentialsX:2.xfrom
SrBedrock:dev/fix-async-event

Conversation

@SrBedrock
Copy link
Contributor

Adds a call to super with the correct async flag based on Bukkit's primary thread status, ensuring proper event handling for TeleportWarmupCancelledEvent.

fix this error:

[18:40:31 WARN]: [Essentials] Plugin Essentials v2.22.0-dev+278-984a0c1 generated an exception while executing task 156164
java.lang.IllegalStateException: TeleportWarmupCancelledEvent may only be triggered synchronously.
        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:42) ~[paper-1.21.10.jar:1.21.10-117-df4b668]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:131) ~[paper-1.21.10.jar:1.21.10-117-df4b668]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:628) ~[paper-api-1.21.10-R0.1-SNAPSHOT.jar:?]
        at EssentialsX-2.22.0-278.jar/com.earth2me.essentials.AsyncTimedTeleport.cancelTimer(AsyncTimedTeleport.java:160) ~[EssentialsX-2.22.0-278.jar:?]
        at EssentialsX-2.22.0-278.jar/com.earth2me.essentials.AsyncTimedTeleport.run(AsyncTimedTeleport.java:96) ~[EssentialsX-2.22.0-278.jar:?]
        at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:78) ~[paper-1.21.10.jar:1.21.10-117-df4b668]
        at org.bukkit.craftbukkit.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57) ~[paper-1.21.10.jar:1.21.10-117-df4b668]
        at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[paper-1.21.10.jar:?]
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
        at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

Adds a call to super with the correct async flag based on Bukkit's primary thread status, ensuring proper event handling for TeleportWarmupCancelledEvent.
Moved the TeleportType import to follow standard import ordering in TeleportWarmupCancelledEvent.java for improved code readability.
Copy link
Member

@JRoy JRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🙏

@JRoy JRoy added this pull request to the merge queue Dec 2, 2025
Merged via the queue into EssentialsX:2.x with commit faa02b5 Dec 2, 2025
1 check passed
Euphillya added a commit to Euphillya/Essentials-Folia that referenced this pull request Dec 17, 2025
EssentialsX@faa02b5 Fix event thread assignment in TeleportWarmupCancelledEvent (EssentialsX#6371)
EssentialsX@b0ef568 Update to Minecraft 1.21.11 (EssentialsX#6364)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants