Add option to limit baltop entries#6300
Conversation
JRoy
left a comment
There was a problem hiding this comment.
i suppose this is okay but wouldn't this literally be like MAYBE a KB of data? the actual user data doesn't stay loaded in memory
|
A KB of data could fit ~ 10-15 players, java object header sizes should also be taken into account. This calculation does not include But it's not just about memory. I've often seen people want to limit the balance to, say, three pages, because in practice, there's another side effect of showing so many entries. Players can simply iterate through balance pages and thus see the exact amount of money that other players have, which isn't desirable on every server (after all, the 'essentials.balance.others' permission isn't given out to everybody). I don't see a reason not to merge this small change, but if you have any concerns, feel free to ask |
Essentials/src/main/java/com/earth2me/essentials/BalanceTopImpl.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/BalanceTopImpl.java
Outdated
Show resolved
Hide resolved
EssentialsX@ca7f3b5 Add option to limit baltop entries (EssentialsX#6300) EssentialsX@893bae0 Change baltop entry limit wording (EssentialsX#6306) EssentialsX@65120e9 Update to Minecraft 1.21.9 (EssentialsX#6299) EssentialsX@22b4975 Fixes stale cached locations after using /settpr (EssentialsX#6305) EssentialsX@8982aae Fix updating join message when not needed (EssentialsX#6312) EssentialsX@4dabeb5 Fix GeoIP dependencies (EssentialsX#6314) EssentialsX@264b0ed Improve memory resilience with Configurate (EssentialsX#6266)
Uh oh!
There was an error while loading. Please reload this page.