Use player's max health instead of the default health value on heal s…#5752
Merged
pop4959 merged 1 commit intoEssentialsX:2.xfrom Mar 31, 2024
Merged
Use player's max health instead of the default health value on heal s…#5752pop4959 merged 1 commit intoEssentialsX:2.xfrom
pop4959 merged 1 commit intoEssentialsX:2.xfrom
Conversation
pop4959
approved these changes
Mar 31, 2024
pop4959
added
type: bugfix
HarvelsX
pushed a commit
to HarvelsX/Essentials
that referenced
this pull request
Jun 2, 2024
Starmism
pushed a commit
to valence-smp/Essentials
that referenced
this pull request
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #5751.
Details
Proposed fix:
Use the player's maximum health, instead of the default health value of 20, upon heal sign interaction.
Environments tested:
OS: Windows 11
Java version: OpenJDK Runtime Environment Corretto-21.0.2.13.1
Demonstration:
Before implementing suggested fix:
https://github.com/EssentialsX/Essentials/assets/44745161/a7e7919f-97aa-434e-84a6-50d5b829633e
After:
https://github.com/EssentialsX/Essentials/assets/44745161/1051e669-1eed-44b9-a1cd-bd8fb8a17312