Strict parsing for legacy converted placeholders#5740
Merged
JRoy merged 1 commit intoEssentialsX:2.xfrom Mar 11, 2024
Merged
Conversation
pop4959
added
type: bugfix
3 tasks
JRoy
approved these changes
Mar 11, 2024
HarvelsX
pushed a commit
to HarvelsX/Essentials
that referenced
this pull request
Jun 2, 2024
This fixes issues where arguments converted implicitly from MiniMessage are prone to bleeding into the rest of the output. The fix mostly works since `MINI_MESSAGE_NO_TAGS` is only used for legacy conversion, while `miniMessageInstance` is used in all other cases normally. If that were not the case, we would not want strict parsing everywhere since we don't enforce this in translations anyway. Fixes EssentialsX#5729 Fixes EssentialsX#5730 Fixes EssentialsX#5732 Fixes EssentialsX#5735 Fixes EssentialsX#5720 Closes EssentialsX#5728
Starmism
pushed a commit
to valence-smp/Essentials
that referenced
this pull request
Jan 8, 2025
This fixes issues where arguments converted implicitly from MiniMessage are prone to bleeding into the rest of the output. The fix mostly works since `MINI_MESSAGE_NO_TAGS` is only used for legacy conversion, while `miniMessageInstance` is used in all other cases normally. If that were not the case, we would not want strict parsing everywhere since we don't enforce this in translations anyway. Fixes EssentialsX#5729 Fixes EssentialsX#5730 Fixes EssentialsX#5732 Fixes EssentialsX#5735 Fixes EssentialsX#5720 Closes EssentialsX#5728
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issues where arguments converted implicitly from MiniMessage are prone to bleeding into the rest of the output.
The fix mostly works since
MINI_MESSAGE_NO_TAGSis only used for legacy conversion, whileminiMessageInstanceis used in all other cases normally. If that were not the case, we would not want strict parsing everywhere since we don't enforce this in translations anyway.Fixes #5729
Fixes #5730
Fixes #5732
Fixes #5735
Fixes #5720
Closes #5728