This repository was archived by the owner on Mar 1, 2024. It is now read-only.
Fix for build-all script dependencies#453
Merged
mcottontensor merged 4 commits intoEpicGames:masterfrom Jan 24, 2024
Merged
Conversation
Contributor
|
PRs go stale after 30 days of inactivity. Please comment or re-open the PR if you are still working on this PR. |
mcottontensor
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Fix for "build-all" script in the typescript implementation, where a second build will fail for seemingly invalid dependencies.
#183
If you perform the steps to build as laid out in the readme they go as follows:
Start by deleting every "node_modules" directory to start fresh
cd ../Frontend/library
npm install
npm run build
cd ../Frontend/ui-library
npm install
npm run build-all
cd ../Frontent/implementations/typescript
npm install
npm run build-all
If this is your first time running, it may succeed. If you run "build-all" on the typescript package a second time is when it fails. The failure is not obvious, other than saying "cannot set value on null" or something to that effect.
If you look at the "build-all" scripts referenced above, both ui-library and typescript perform an npm link on the library package, and I believe that is the cause of the issue. Simply moving the link to after the library and ui-library have built prevents the "double link" on the library directory.
Solution
The build-all script is updated to perform the build and build-all of library and ui-library before performing the npm link and running the build script on the typescript package.
Documentation
n/a
Test Plan and Compatibility
n/a