Skip to content

ci: add critical check workflow#74

Merged
ripel2 merged 6 commits into
mainfrom
62-define-criticalnot-critical-issues
Feb 7, 2025
Merged

ci: add critical check workflow#74
ripel2 merged 6 commits into
mainfrom
62-define-criticalnot-critical-issues

Conversation

@Miou-zora

Copy link
Copy Markdown
Contributor

Related to:

I added a way to run a specific job when a PR is critical, and if that's the case, it will check that all @EngineSquared/coreteam members validate the PR before merging.

I also added a note inside the CONTRIBUTING.md file indicating the process to follow when using the "critical" label.

@Miou-zora Miou-zora added the ci Everything related to continous integration label Dec 23, 2024
@Miou-zora Miou-zora self-assigned this Dec 23, 2024
@Miou-zora Miou-zora linked an issue Dec 23, 2024 that may be closed by this pull request
@Miou-zora Miou-zora force-pushed the 62-define-criticalnot-critical-issues branch from 745ed60 to 5437033 Compare December 23, 2024 07:27
@Miou-zora

Copy link
Copy Markdown
Contributor Author

As an example, I will put this PR as "critical".

@Miou-zora Miou-zora added the critical Very important PR that requires @CoreTeam approval label Dec 23, 2024
@sonarqubecloud

Copy link
Copy Markdown

@Miou-zora Miou-zora changed the title CI: add critical check workflow ci: add critical check workflow Dec 25, 2024
@Miou-zora Miou-zora requested a review from Divengerss February 7, 2025 13:15
@sonarqubecloud

sonarqubecloud Bot commented Feb 7, 2025

Copy link
Copy Markdown

@ripel2 ripel2 merged commit 47d8e2c into main Feb 7, 2025
@ripel2 ripel2 deleted the 62-define-criticalnot-critical-issues branch February 7, 2025 13:23
MasterLaplace pushed a commit that referenced this pull request Feb 12, 2025
Related to:
- #62 

I added a way to run a specific job when a PR is critical, and if that's
the case, it will check that all @EngineSquared/coreteam members
validate the PR before merging.

I also added a note inside the `CONTRIBUTING.md` file indicating the
process to follow when using the "critical" label.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Everything related to continous integration critical Very important PR that requires @CoreTeam approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define critical/not critical issues

4 participants