src/plugin/default-pipeline/src/resource/pass/Shadow.hpp (1)

93-93: Consider renaming shadowTextureView to reflect ID semantics.

This assignment now passes an ID (depthTextureViewId), so keeping the source field name as shadowTextureView can be misleading for future call sites.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/plugin/default-pipeline/src/resource/pass/Shadow.hpp` at line 93, The
field lightGPUComponent.shadowTextureView is misleading because it actually
holds an ID assigned to outputs.depthBuffer->depthTextureViewId; rename the
field to shadowTextureViewId across the LightGPUComponent (or whatever
class/struct defines it) and update all usages (including the assignment
outputs.depthBuffer->depthTextureViewId = lightGPUComponent.shadowTextureViewId)
to reflect the ID semantics while keeping the underlying type unchanged; ensure
any serialization, constructors, or comments referencing shadowTextureView are
updated too.

src/plugin/default-pipeline/src/component/GPUDirectionalLight.hpp (1)

20-21: Use = default for the trivial destructor.

The empty destructor should use = default instead of an empty body. This follows modern C++ best practices and allows the compiler to potentially optimize better.

♻️ Proposed fix

-    ~GPUDirectionalLight() {}
-
+    ~GPUDirectionalLight() = default;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/plugin/default-pipeline/src/component/GPUDirectionalLight.hpp` around
lines 20 - 21, Replace the trivial empty destructor definition
"~GPUDirectionalLight() {}" in the GPUDirectionalLight class with a defaulted
destructor using "= default;" (i.e., make ~GPUDirectionalLight() = default;) so
the compiler can treat it as a defaulted special member; update the
declaration/definition where "~GPUDirectionalLight()" appears in
GPUDirectionalLight.hpp accordingly.

src/plugin/graphic/src/resource/TextureView.hpp (2)

50-50: Add explicit to the conversion operator.

Implicit conversion operators can cause unintended type conversions and make code harder to reason about. Since GetWebGPUView() already provides explicit access to the underlying handle, consider making this conversion explicit.

♻️ Proposed fix

-    operator wgpu::TextureView() const { return _webgpuView; }
+    explicit operator wgpu::TextureView() const { return _webgpuView; }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/plugin/graphic/src/resource/TextureView.hpp` at line 50, Mark the
conversion operator operator wgpu::TextureView() const as explicit to prevent
implicit conversions; update the declaration/definition of that operator to be
explicit and ensure existing call sites use either GetWebGPUView() or an
explicit cast (e.g., static_cast<wgpu::TextureView>(...)) where needed.

---

3-17: Remove unnecessary includes.

This header only defines a simple wrapper around wgpu::TextureView. The includes for Image.hpp, GetBytesPerPixel.hpp, <array>, <bit>, <cstddef>, <cstdint>, <cstring>, <functional>, <glm/gtc/packing.hpp>, <glm/vec2.hpp>, <glm/vec4.hpp>, and <vector> appear to be copy-pasted from Texture.hpp and are not used here.

♻️ Proposed fix

 `#pragma` once

-#include "exception/UnsupportedTextureFormatError.hpp"
-#include "resource/Context.hpp"
-#include "resource/Image.hpp"
-#include "utils/GetBytesPerPixel.hpp"
 `#include` "utils/webgpu.hpp"
-#include <array>
-#include <bit>
-#include <cstddef>
-#include <cstdint>
-#include <cstring>
-#include <functional>
-#include <glm/gtc/packing.hpp>
-#include <glm/vec2.hpp>
-#include <glm/vec4.hpp>
-#include <vector>

 namespace Graphic::Resource {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/plugin/graphic/src/resource/TextureView.hpp` around lines 3 - 17,
TextureView.hpp currently pulls in many unused headers copied from Texture.hpp;
remove the unnecessary includes (Image.hpp, GetBytesPerPixel.hpp, <array>,
<bit>, <cstddef>, <cstdint>, <cstring>, <functional>, <glm/gtc/packing.hpp>,
<glm/vec2.hpp>, <glm/vec4.hpp>, and <vector>) and keep only the headers required
for the simple wrapper around wgpu::TextureView (e.g., utils/webgpu.hpp and any
minimal exception or forward-declaration headers actually referenced by the
TextureView class); update the include list in TextureView.hpp so it only
contains the minimal set needed by the TextureView symbol and any directly used
types like UnsupportedTextureFormatError if it is used.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes