refactor(window): using glm ivec2 to handle window size#202
Merged
Conversation
Miou-zora
requested changes
Apr 25, 2025
| private: | ||
| uint32_t _width; | ||
| uint32_t _height; | ||
| glm::ivec2 _size; |
Contributor
There was a problem hiding this comment.
You can totally remove _size as we don't use it anywhere.
Miou-zora
approved these changes
Apr 26, 2025
|
MasterLaplace
pushed a commit
that referenced
this pull request
Apr 29, 2025
Related to: - #171 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Miouzora <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: