Skip to content

refactor(OpenGL): use existing object plugin in opengl#140

Merged
ripel2 merged 34 commits into
mainfrom
121-use-existing-object-plugin-in-opengl
Mar 23, 2025
Merged

refactor(OpenGL): use existing object plugin in opengl#140
ripel2 merged 34 commits into
mainfrom
121-use-existing-object-plugin-in-opengl

Conversation

@MasterLaplace

@MasterLaplace MasterLaplace commented Mar 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

MasterLaplace and others added 15 commits March 21, 2025 06:52
@MasterLaplace
feat(OBJLoader): add Vulkan support for texture coordinate inversion
bf1b092
@MasterLaplace
feat(GLBuffer): add a GLBuffer class to manage OpenGL buffers
c69c6c7
@github-actions
style: apply linter
749f9af
@MasterLaplace
feat(GLBufferManager): add a GLBufferManager class to manage GLBuffers
de6d277
@MasterLaplace
feat(Mesh): add methods to retrieve vertices, normals, and texture co…
83e3477 
…ordinates
@MasterLaplace
fixOBJLoader): add support for normals and conditional texture coordi…
a41edd5 
…nates
@github-actions
style: apply linter
1077aff
@MasterLaplace
feat(Vertex): replace color with normal in Vertex structure
c502b7b
@MasterLaplace
feat(OpenGL): refactor model structure and remove Mesh class
b4fe0c8
@MasterLaplace
fix(Vertex): replace color with normal in Vertex tests and Mesh copy …
1e7abd9 
…constructor
@MasterLaplace
feat(GLBuffer): add update method for mesh data and integrate with re…
d33fe63 
…ndering system
@github-actions
style: apply linter
2523504
@MasterLaplace
feat(OpenGL): implement move semantics for Mesh and update GLBuffer i…
0aef261 
…ntegration
@github-actions
style: apply linter
579716a
@MasterLaplace
fix(GLBuffer): add move semantics to GLBuffer class and update resour…
a6fbac4 
…ce loading
@MasterLaplace MasterLaplace added the refactor Code Refactor label Mar 21, 2025
@MasterLaplace MasterLaplace self-assigned this Mar 21, 2025
@MasterLaplace MasterLaplace linked an issue Mar 21, 2025 that may be closed by this pull request
Use existing Object plugin in OpenGL #121
Closed
@MasterLaplace MasterLaplace marked this pull request as draft March 21, 2025 13:48
@MasterLaplace MasterLaplace requested review from Miou-zora and ripel2 and removed request for ripel2 March 21, 2025 21:13
@MasterLaplace MasterLaplace marked this pull request as ready for review March 21, 2025 21:22
ripel2
ripel2 suggested changes Mar 22, 2025
View reviewed changes
Comment thread src/plugin/object/src/component/Mesh.hpp Outdated
Comment thread src/plugin/object/src/resource/OBJLoader.hpp
Comment thread src/plugin/opengl/src/resource/GLBuffer/GLBuffer.hpp Outdated
Comment thread src/plugin/opengl/src/resource/GLBuffer/GLBuffer.hpp Outdated
Comment thread src/plugin/opengl/src/system/AllSystems.cpp Outdated
@ripel2

ripel2 commented Mar 22, 2025

Copy link
Copy Markdown
Contributor

also, next time please ask for the review of the whole team @EngineSquared/coreteam

MasterLaplace and others added 9 commits March 22, 2025 15:18
@MasterLaplace
fix(Mesh): replace include guards with #pragma once for improved read…
5ceee03 
…ability
@MasterLaplace
refactor(GLBuffer): refactor GLBuffer management into separate files …
89584fe 
…for better organization
@MasterLaplace
fix(xmake): reorganize include directories for better structure
e8d5b95
@MasterLaplace
fix(OpenGL): update GLBuffer references and add noexcept to methods f…
a11f090 
…or better safety
@github-actions
style: apply linter
6de9895
@MasterLaplace
fix(GLBuffer): change destroyGlBuffers and update methods to const no…
b0469e0 
…except for better safety
@MasterLaplace
feat(OpenGL): add GLBufferManager loading and update GLBuffer handlin…
391b944 
…g for improved resource management
@MasterLaplace
fix(xmake): reorganize include directories and add PluginRelationship…
e9daa08 
… dependency
@MasterLaplace
feat(Component): add default copy/move constructors and assignment op…
8d573c6 
…erators
@MasterLaplace MasterLaplace requested review from a team and removed request for Miou-zora March 23, 2025 09:55
@MasterLaplace MasterLaplace requested a review from ripel2 March 23, 2025 12:04
@ripel2 ripel2 enabled auto-merge (squash) March 23, 2025 12:05
@sonarqubecloud

sonarqubecloud Bot commented Mar 23, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ripel2 ripel2 merged commit b07457b into main Mar 23, 2025
@ripel2 ripel2 deleted the 121-use-existing-object-plugin-in-opengl branch March 23, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ripel2 ripel2 ripel2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MasterLaplace MasterLaplace

Labels

refactor Code Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use existing Object plugin in OpenGL

2 participants

@MasterLaplace @ripel2