feat(Log): add logging in Entity class#118
Merged
ripel2 merged 13 commits intoMar 19, 2025
Merged
Conversation
…stroy-and-entities-creation-and-destruction
…ntities-creation-and-destruction' of https://github.com/EngineSquared/EngineSquared into 106-log-components-assignation-update-and-destroy-and-entities-creation-and-destruction
…stroy-and-entities-creation-and-destruction
ripel2
suggested changes
Mar 16, 2025
Contributor
ripel2
left a comment
ripel2
left a comment
There was a problem hiding this comment.
just change the name of the define please
|
|
||
| ES::Engine::Core::Core() : _registry(nullptr) | ||
| { | ||
| #ifdef DEBUG |
Contributor
There was a problem hiding this comment.
"DEBUG" is a bit vague and could be used by other libraries and/or by some of our users
Contributor
Author
There was a problem hiding this comment.
Done but later we should think about having a easier and better logging: when we want to log only entities or plugins or systems.
ripel2
approved these changes
Mar 18, 2025
…stroy-and-entities-creation-and-destruction
…stroy-and-entities-creation-and-destruction
|
ripel2
deleted the
106-log-components-assignation-update-and-destroy-and-entities-creation-and-destruction
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to:
I've added logging in entity as it's the easier way to do logging