Fix new warnings & remove manual suppressions#668
Merged
desilinguist merged 4 commits intomainfrom Jan 8, 2024
Merged
Conversation
The new version of matplotlib discourages the use of `set_xticklabels()` and displays warnings in the notebook. The recommended replacement is to use `set_xticks()` instead.
Seaborn is deprecating the `scale` parameter and encourages the use of matplotlib Line2D parameters directly, i.e., `markersize`. However, the units are different.
The latest version of seaborn and matplotlib no longer generate the two types of warnings we were manually suppressing.
desilinguist
requested review from
Frost45,
damien2012eng,
mulhod and
tamarl08
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 32 32
Lines 4489 4489
=======================================
Hits 4302 4302
Misses 187 187 ☔ View full report in Codecov by Sentry. |
Contributor
|
Looks good, no warnings, tests passed with 3.8! |
tamarl08
approved these changes
Jan 8, 2024
Fix the layout for the built-in model diagnostic plots that were being cut off.
damien2012eng
approved these changes
Jan 8, 2024
Member
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_xticklabels()calls in several notebooks since the new version of matplotlib discourages the use ofset_xticklabels()and displays warnings in the notebooks. The recommended replacement is to useset_xticks()instead.scaleinsns.catplot()sinceseabornis deprecating thescaleparameter and encourages the use ofmatplotlibLine2D parameters directly, i.e.,markersize. However, the units are different.seabornandmatplotlibno longer generate the two types of warnings we were manually suppressing.I ran
STRICT=1 nose2 -s testsand all tests passed which means there were no warnings generated in notebooks. To double check, I rangrep ' output_stderr ' test_outputs/*/report/*.htmland this confirmed that there were no unexpected warnings generated.To review:
STRICT=1 nose2 -s testsusing a python 3.8 environment (mine was 3.11) and check that there were no warnings generated using the methods I suggested above.Closes #655.