Unpin dependencies and fix minor issues#666
Merged
desilinguist merged 5 commits intomainfrom Jan 4, 2024
Merged
Conversation
- Also update SKLL to v4.0.1.
Update all RSMTool models to be compatible with latest SKLL and scikit-learn.
Use `map()` instead of the deprecated `applymap()`.
Update dependency versions in `doc/requirements.txt`.
desilinguist
requested review from
Frost45,
damien2012eng,
mulhod and
tamarl08
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #666 +/- ##
==========================================
- Coverage 95.85% 95.83% -0.02%
==========================================
Files 32 32
Lines 4485 4488 +3
==========================================
+ Hits 4299 4301 +2
- Misses 186 187 +1 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
We can ignore the change in coverage since this build uses python 3.8 and the decrease is expected. |
Frost45
approved these changes
Jan 4, 2024
tamarl08
approved these changes
Jan 4, 2024
damien2012eng
approved these changes
Jan 4, 2024
This was referenced Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requirements.txtand update SKLL to v4.0.1.applymap()method for Python versions > 3.8 to avoid deprecation warnings.