Conversation
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
Contributor
|
I'd like to try these changes in a real scenario. Perhaps we can work together to do that, but it will take some work to do before this is a package that can be installed. |
mulhod
approved these changes
Sep 28, 2023
Collaborator
Co-authored-by: Matt Mulholland <[email protected]>
mulhod
reviewed
Sep 28, 2023
added 2 commits
October 2, 2023 09:38
Collaborator
desilinguist
requested changes
Oct 2, 2023
Collaborator
desilinguist
left a comment
desilinguist
left a comment
There was a problem hiding this comment.
Actually, now that I think about it, we should mention the section stuff in documentation somewhere right?
mulhod
approved these changes
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metrics are logged to different sections according to the context (rsmtool, rsmeval etc.). That way they appear separately on the W&B run and do not overwrite when more than one module log the same metrics.
All reports are logged to a
reportssection.This PR also updates the RTD configuration to meet the new format of the
buildsection.