Merged
Conversation
desilinguist
requested review from
Frost45,
amandameganchan,
blongwill,
damien2012eng,
dblandan,
mulhod,
tamarl08 and
tazin-afrin
Codecov ReportBase: 93.20% // Head: 93.20% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
=======================================
Coverage 93.20% 93.20%
=======================================
Files 31 31
Lines 4549 4549
=======================================
Hits 4240 4240
Misses 309 309
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dblandan
approved these changes
Jan 22, 2023
damien2012eng
approved these changes
Jan 23, 2023
tamarl08
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release PR for v9.1.1 makes the following changes:
MANIFEST.into includerequirements.txtin the PyPI package which is required now.Note: I had to use v9.1.1 because the TestPyPI package for v9.1.0 failed (due to missing
requirements.txt) and TestPyPI doesn't let you reuse version numbers once they have been uploaded. I figured 9.1.1 was better than something like 9.1.0.post1, which is what they recommend.The conda and TestPyPI packages were built and uploaded. Both pass tests as shown in these PRs:
As always, please test both the conda and TestPyPI package locally on either Linux or macOS by installing them and trying to run some small tests or one of the examples.
mamba create -n rsmtest -c ets -c conda-forge python=3.9 rsmtool. You can choose to use Python 3.8, 3.9, or 3.10.pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple rsmtool "pandas>=1.5" "numpy>=1.24" "matplotlib>=3.6" "jupyter_server>=2.0" "notebook-shim>=0.2.0".