Disallow negative confidence intervals.#574
Merged
desilinguist merged 1 commit intomainfrom Dec 1, 2022
Merged
Conversation
desilinguist
requested review from
Frost45,
damien2012eng,
mulhod and
tamarl08
Codecov ReportBase: 91.81% // Head: 95.74% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
==========================================
+ Coverage 91.81% 95.74% +3.92%
==========================================
Files 29 29
Lines 3996 3996
==========================================
+ Hits 3669 3826 +157
+ Misses 327 170 -157
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tamarl08
approved these changes
Dec 1, 2022
Frost45
approved these changes
Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute confidence intervals using absolute values so that we don't compute negative ones that pandas & Matplotlib complain about.