Skip to content

Release/v9.0#566

Merged
desilinguist merged 10 commits intomainfrom
release/v9.0
Mar 9, 2022
Merged

Release/v9.0#566
desilinguist merged 10 commits intomainfrom
release/v9.0

Conversation

@desilinguist
Copy link
Copy Markdown
Collaborator

@desilinguist desilinguist commented Mar 9, 2022 •
edited
Loading

Changes

  • Update version number.
  • Make conda package noarch again.
  • Update release process document for noarch package and other changes.
  • Fix broken link in index.rst.
  • Update package manifest to exclude more temporary files.
  • Update README with the correct python versions and fix outdated link.
  • This finally resolves Drop support for Python 3.7 #554 as there should be no more trace of Python 3.7.

Package status

How to review

In addition to reviewing the changes in the PR, please try testing various combinations of {pip, conda} x {Linux, macOS} x (3.8, 3.9, 3.10}.

@desilinguist desilinguist requested review from Frost45 and mulhod March 9, 2022 14:48
@desilinguist desilinguist self-assigned this Mar 9, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 9, 2022 •
edited
Loading

Codecov Report

Merging #566 (dd12783) into main (9db3291) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #566   +/-   ##
=======================================
  Coverage   93.14%   93.14%           
=======================================
  Files          31       31           
  Lines        4525     4525           
=======================================
  Hits         4215     4215           
  Misses        310      310
Impacted Files Coverage Δ
rsmtool/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db3291...dd12783. Read the comment docs.

@Frost45
Copy link
Copy Markdown
Contributor

Frost45 commented Mar 9, 2022 •
edited
Loading

Since we are dropping support for Python 3.7, I think the installation page in the documentation needs to be fixed too. https://rsmtool.readthedocs.io/en/main/getting_started.html

@desilinguist
Copy link
Copy Markdown
Collaborator Author

desilinguist commented Mar 9, 2022 •
edited
Loading

Since we are dropping support for Python 3.7, I think the installation page in the documentation needs to be fixed too. https://rsmtool.readthedocs.io/en/main/getting_started.html

Good catch! Fixed locally. Will push all changes together.

Frost45
Frost45 approved these changes Mar 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Frost45 Frost45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried the rsmxval tutorial on MacOS x {pip, conda} x {3.8, 3.9, 3.10}. Works perfectly! Thank you for doing this 🎉

mulhod
mulhod approved these changes Mar 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mulhod mulhod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested rsmtool, rsmeval, and rsmxval with Python 3.8/3.9/3.10 on Linux.

@desilinguist desilinguist merged commit 933d17b into main Mar 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the release/v9.0 branch March 9, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frost45 Frost45 Frost45 approved these changes

+1 more reviewer

@mulhod mulhod mulhod approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@desilinguist desilinguist

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.7

3 participants

@desilinguist @Frost45 @mulhod