fixed commands to show tcp/IP and changed os versions for linux to Ub… by matt-auzone · Pull Request #10 · EdgeFirstAI/samples

matt-auzone · 2025-11-19T22:09:08Z

…untu 22.04 to match Maivin with glibc 2.35

Description

Brief summary of changes and their purpose.

Type of Change

Bug fix (non-breaking change fixing an issue)
New feature (non-breaking change adding functionality)
New example (adds a new example demonstrating functionality)
Breaking change (fix or feature causing existing functionality to change)
Documentation update
Performance improvement
Code refactoring

Related Issues

Fixes #(issue number)
Related to #(issue number)

Testing

Describe how you tested your changes:

Test details:

Checklist

License Compliance

If you added new dependencies:

All dependencies use approved licenses (see CONTRIBUTING.md)
SBOM regenerated (bash .github/scripts/generate_sbom.sh)
License policy check passes (python3 .github/scripts/check_license_policy.py sbom.json)
NOTICE file updated

Screenshots/Logs

Add relevant screenshots or logs demonstrating the change (if applicable).

Additional Notes

Any additional information reviewers should know.

…untu 22.04 to match Maivin with glibc 2.35

Copilot

Pull Request Overview

This PR updates command-line help text to clarify the remote endpoint format and updates the CI/CD Ubuntu runner versions. The changes include adding "tcp/" prefix to remote connection examples throughout the codebase and standardizing on Ubuntu 22.04 for GitHub Actions workflows to match Maivin's glibc 2.35 requirement.

Updated --remote argument help text across all Python sample scripts to specify format as tcp/IP:7447
Changed GitHub Actions workflow from ubuntu-latest to ubuntu-22.04 for x86_64 builds and ubuntu-22.04-arm for aarch64 builds
Updated all documentation examples (README.md, QUICKSTART.md, AGENTS.md) to include the tcp/ prefix in remote endpoint examples

Reviewed Changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 32 comments.

Show a summary per file

File	Description
python/radar/targets.py	Updated --remote help text to show tcp/IP format
python/radar/info.py	Updated --remote help text to show tcp/IP format
python/radar/cube.py	Updated --remote help text to show tcp/IP format
python/radar/clusters.py	Updated --remote help text to show tcp/IP format
python/model/model_info.py	Updated --remote help text to show tcp/IP format
python/model/mask.py	Updated --remote help text to show tcp/IP format
python/model/compressed_mask.py	Updated --remote help text to show tcp/IP format
python/model/boxes2d_tracked.py	Updated --remote help text to show tcp/IP format
python/model/boxes2d.py	Updated --remote help text to show tcp/IP format
python/list-topics.py	Updated --remote help text and introduced variable naming error
python/lidar/reflect.py	Updated --remote help text to show tcp/IP format
python/lidar/points.py	Updated --remote help text to show tcp/IP format
python/lidar/depth.py	Updated --remote help text to show tcp/IP format
python/lidar/clusters.py	Updated --remote help text to show tcp/IP format
python/imu.py	Updated --remote help text to show tcp/IP format
python/gps.py	Updated --remote help text to show tcp/IP format
python/fusion/radar.py	Updated --remote help text to show tcp/IP format
python/fusion/occupancy.py	Updated --remote help text to show tcp/IP format
python/fusion/model_output_tracked.py	Updated --remote help text to show tcp/IP format
python/fusion/model_output.py	Updated --remote help text to show tcp/IP format
python/fusion/lidar.py	Updated --remote help text to show tcp/IP format
python/fusion/boxes3d.py	Updated --remote help text to show tcp/IP format
python/combined/mega_sample.py	Updated --remote help text to show tcp/IP format
python/combined/camera_radar.py	Updated --remote help text to show tcp/IP format
python/combined/camera_model.py	Updated --remote help text to show tcp/IP format
python/combined/camera_lidar.py	Updated --remote help text to show tcp/IP format
python/camera/jpeg.py	Updated --remote help text to show tcp/IP format
python/camera/h264.py	Updated --remote help text to show tcp/IP format
python/camera/dma.py	Updated --remote help text to show tcp/IP format
python/camera/camera_info.py	Updated --remote help text to show tcp/IP format
README.md	Updated remote connection examples to use tcp/ prefix
QUICKSTART.md	Updated remote connection examples to use tcp/ prefix
AGENTS.md	Updated remote connection examples to use tcp/ prefix
.github/workflows/release.yml	Changed Ubuntu runner versions to ubuntu-22.04 and ubuntu-22.04-arm

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-19T22:15:38Z

        type=str,
        default=None,
-        help="Connect to the remote endpoint instead of local.",
+        help="Connect to remote endpoint (format: tcp/IP:7447)",


The format string "tcp/IP:7447" is ambiguous. "IP" could be confused with the TCP/IP protocol suite. Consider using a clearer placeholder like "tcp/<IP_ADDRESS>:7447" or "tcp/HOST:7447" to make it obvious that IP should be replaced with an actual IP address.

Suggested change

help="Connect to remote endpoint (format: tcp/IP:7447)",

help="Connect to remote endpoint (format: tcp/<IP_ADDRESS>:7447)",

Copilot · 2025-11-19T22:15:39Z

        type=str,
        default=None,
-        help="Connect to the remote endpoint instead of local.",
+        help="Connect to remote endpoint (format: tcp/IP:7447)",


The format string "tcp/IP:7447" is ambiguous. "IP" could be confused with the TCP/IP protocol suite. Consider using a clearer placeholder like "tcp/<IP_ADDRESS>:7447" or "tcp/HOST:7447" to make it obvious that IP should be replaced with an actual IP address.

Suggested change

help="Connect to remote endpoint (format: tcp/IP:7447)",

help="Connect to remote endpoint (format: tcp/<IP_ADDRESS>:7447)",

Copilot · 2025-11-19T22:15:39Z

        type=str,
        default=None,
-        help="Connect to the remote endpoint instead of local.",
+        help="Connect to remote endpoint (format: tcp/IP:7447)",


The format string "tcp/IP:7447" is ambiguous. "IP" could be confused with the TCP/IP protocol suite. Consider using a clearer placeholder like "tcp/<IP_ADDRESS>:7447" or "tcp/HOST:7447" to make it obvious that IP should be replaced with an actual IP address.

Suggested change

help="Connect to remote endpoint (format: tcp/IP:7447)",

help="Connect to remote endpoint (format: tcp/<IP_ADDRESS>:7447)",

Copilot · 2025-11-19T22:15:39Z

        type=str,
        default=None,
-        help="Connect to the remote endpoint instead of local.",
+        help="Connect to remote endpoint (format: tcp/IP:7447)",


The format string "tcp/IP:7447" is ambiguous. "IP" could be confused with the TCP/IP protocol suite. Consider using a clearer placeholder like "tcp/<IP_ADDRESS>:7447" or "tcp/HOST:7447" to make it obvious that IP should be replaced with an actual IP address.

Suggested change

help="Connect to remote endpoint (format: tcp/IP:7447)",

help="Connect to remote endpoint (format: tcp/<IP_ADDRESS>:7447)",

Copilot · 2025-11-19T22:15:46Z

            archive_name: edgefirst-samples-linux-x86_64
          # Linux aarch64
-          - os: ubuntu-latest
+          - os: ubuntu-22.04-arm


ubuntu-22.04-arm is not a standard GitHub-hosted runner. GitHub Actions only provides ubuntu-latest, ubuntu-22.04, and ubuntu-20.04 for Ubuntu runners. If this is intended to reference a self-hosted runner with the label ubuntu-22.04-arm, ensure that such a runner is configured in your repository. Otherwise, this will cause the workflow to fail with a "no runner" error.

Suggested change

- os: ubuntu-22.04-arm

- os: ubuntu-22.04

ubuntu-22.04-arm is valid.

Copilot · 2025-11-19T22:15:46Z

        type=str,
        default=None,
-        help="Connect to the remote endpoint instead of local.",
+        help="Connect to remote endpoint (format: tcp/IP:7447)",


The format string "tcp/IP:7447" is ambiguous. "IP" could be confused with the TCP/IP protocol suite. Consider using a clearer placeholder like "tcp/<IP_ADDRESS>:7447" or "tcp/HOST:7447" to make it obvious that IP should be replaced with an actual IP address.

Copilot · 2025-11-19T22:15:47Z

        type=str,
        default=None,
-        help="Connect to the remote endpoint instead of local.",
+        help="Connect to remote endpoint (format: tcp/IP:7447)",


The format string "tcp/IP:7447" is ambiguous. "IP" could be confused with the TCP/IP protocol suite. Consider using a clearer placeholder like "tcp/<IP_ADDRESS>:7447" or "tcp/HOST:7447" to make it obvious that IP should be replaced with an actual IP address.

Suggested change

help="Connect to remote endpoint (format: tcp/IP:7447)",

help="Connect to remote endpoint (format: tcp/<IP_ADDRESS>:7447)",

Copilot · 2025-11-19T22:15:47Z

        type=str,
        default=None,
-        help="Connect to the remote endpoint instead of local.",
+        help="Connect to remote endpoint (format: tcp/IP:7447)",


The format string "tcp/IP:7447" is ambiguous. "IP" could be confused with the TCP/IP protocol suite. Consider using a clearer placeholder like "tcp/<IP_ADDRESS>:7447" or "tcp/HOST:7447" to make it obvious that IP should be replaced with an actual IP address.

Suggested change

help="Connect to remote endpoint (format: tcp/IP:7447)",

help="Connect to remote endpoint (format: tcp/<IP_ADDRESS>:7447)",

IP_ADDRESS could also be a hostname so we should use the tcp/<HOST>:7447 naming. Co-authored-by: Copilot <[email protected]>

Co-authored-by: Copilot <[email protected]>

sonarqubecloud · 2025-11-24T23:10:23Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fixed commands to show tcp/IP and changed os versions for linux to Ub…

bd76224

…untu 22.04 to match Maivin with glibc 2.35

Copilot AI review requested due to automatic review settings November 19, 2025 22:09

Copilot started reviewing on behalf of matt-auzone November 19, 2025 22:09 View session

Copilot finished reviewing on behalf of matt-auzone November 19, 2025 22:12

Copilot AI reviewed Nov 19, 2025

View reviewed changes

sebastient and others added 2 commits November 24, 2025 16:04

Update python/list-topics.py

e93c492

IP_ADDRESS could also be a hostname so we should use the tcp/<HOST>:7447 naming. Co-authored-by: Copilot <[email protected]>

Update python/list-topics.py

f329f48

Co-authored-by: Copilot <[email protected]>

Navigation Menu

Uh oh!

fixed commands to show tcp/IP and changed os versions for linux to Ub… - #10

fixed commands to show tcp/IP and changed os versions for linux to Ub…#10
matt-auzone wants to merge 3 commits into
mainfrom
EDGEAI-983

matt-auzone commented Nov 19, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Nov 19, 2025

Uh oh!

Copilot AI Nov 19, 2025

Uh oh!

Copilot AI Nov 19, 2025

Uh oh!

Copilot AI Nov 19, 2025

Uh oh!

Copilot AI Nov 19, 2025

Uh oh!

sebastient Nov 24, 2025

Uh oh!

Uh oh!

Copilot AI Nov 19, 2025

Uh oh!

Copilot AI Nov 19, 2025

Uh oh!

Copilot AI Nov 19, 2025

Uh oh!

sonarqubecloud Bot commented Nov 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	help="Connect to remote endpoint (format: tcp/IP:7447)",
	help="Connect to remote endpoint (format: tcp/<IP_ADDRESS>:7447)",

Uh oh!

Conversation

matt-auzone commented Nov 19, 2025

Description

Type of Change

Related Issues

Testing

Checklist

License Compliance

Screenshots/Logs

Additional Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

sebastient Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Nov 24, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants