This repository was archived by the owner on Nov 6, 2023. It is now read-only.
WIP: Add script to trivialize some left-wilcard targets - #17842
Closed
cschanaj wants to merge 3 commits into
Closed
Conversation
Contributor
|
@cschanaj This is justified since it reduces ruleset complexity and improves ruleset testing coverage, which are currently two very important tasks. |
pipboy96
suggested changes
Apr 28, 2019
Contributor
|
Also, the actual |
pipboy96
reviewed
Apr 28, 2019
Contributor
|
Also makes sense to replace rules that are effectively equal to |
Collaborator
Author
AFAIK, |
cschanaj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script will trivialize at least 1.3k left-wildcard targets (nearly 1/3 of their population). In some sense, it seems too good to be true, hope I didn't mess up anything 😄
P.S. benchmark with memusage.js show the memory usage will be increased by 0.6 MB because of this change... if this is not justified, I will close this PR.