Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Create ruleset: Elgas.com.au #15772

Merged
J0WI merged 3 commits into from
Jun 28, 2018
Merged

Create ruleset: Elgas.com.au #15772

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66f7309
Create ruleset: Elgas.com.au
injust Jun 16, 2018
7645206
Remove nonfunctional target
injust Jun 16, 2018
18616d6
Add comment for secure.elgas.com.au
injust Jun 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/chrome/content/rules/Elgas.com.au.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<!--
HTTP redirects to NXDOMAIN:
- secure.elgas.com.au

Invalid certificate:
- lng.elgas.com.au
- trade.elgas.com.au

Wrong server:
- testserver.elgas.com.au
-->

<ruleset name="Elgas.com.au">
<target host="elgas.com.au" />
<target host="www.elgas.com.au" />
<target host="emap.elgas.com.au" />

@J0WI J0WI Jun 16, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

secure.elgas.com.au

@injust injust Jun 16, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That host fails the CI build, because accessing it on HTTP redirects to www.secure.elgas.com.au, which DNE.
Maybe the Travis tests should be modified to allow for sites that only work on HTTPS?

@J0WI J0WI Jun 17, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here is that HTTP serves a different response than HTTPS. Could you document the issue?

@injust injust Jun 26, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a comment for secure.elgas.com.au.
In this case, would it be better to leave the target out of the ruleset, or include it and whitelist the ruleset against fetch tests?

@J0WI J0WI Jun 28, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the expected behavior would be in this case. I'm fine with both variants.


<rule from="^http:" to="https:" />
</ruleset>