bypass S3FS if downloading#187
Merged
Merged
Conversation
bethac07
approved these changes
Dec 4, 2024
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was stuck in a situation where I was trying to work off of CPG in
2.2.0_4.2.8(anderinweisbart:2.2.0rc1_4.2.4) and kept getting an error, possibly something to do with mounting. #186I haven't tracked down what was causing the error yet, but to get around it by downloading files instead of using S3FS, this change needed to be made to run_worker.py (which it seems should be there regardless to prevent other hypothetical problems because there's no need to try to mount bucket with S3FS if you are downloading your files)