Skip to content

Add ES256 JWKS support for OIDC#115

Open
gbw wants to merge 1 commit intoDioCrafts:mainfrom
gbw:feature/es256-jwks-support
Open

Add ES256 JWKS support for OIDC#115
gbw wants to merge 1 commit intoDioCrafts:mainfrom
gbw:feature/es256-jwks-support

Conversation

@gbw
Copy link

@gbw gbw commented Feb 14, 2026

Description

  • Simplified oidc_service.rs to use jsonwebtoken's DecodingKey::from_jwk()
  • Automatically handles key type detection (RSA/EC) and algorithm detection
  • Supports RS256, RS384, RS512, ES256, and ES384 algorithms
  • Much cleaner code by leveraging library's built-in JWK parsing

Related Issue

N/A

Type of Change

Please check the option that best describes your change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Performance improvement
  • Code refactoring
  • Documentation update

How Has This Been Tested?

Tested locally with Kanidm RS256 (existing) and ES256 (new) signing algorithms.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

- Simplified oidc_service.rs to use jsonwebtoken's DecodingKey::from_jwk()
- Automatically handles key type detection (RSA/EC) and algorithm detection
- Supports RS256, RS384, RS512, ES256, and ES384 algorithms
- Much cleaner code by leveraging library's built-in JWK parsing
@gbw gbw requested a review from DioCrafts as a code owner February 14, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant