Skip to content

feat(bpmn-moddle): add v10, retain v9#74628

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
hkleungai:bpmn-moddle-update
Mar 9, 2026
Merged

feat(bpmn-moddle): add v10, retain v9#74628
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
hkleungai:bpmn-moddle-update

Conversation

@hkleungai
Copy link
Copy Markdown
Contributor

@hkleungai hkleungai commented Mar 3, 2026 •
edited
Loading

Add v10. Resolves #74540.

Retain v9. Looks like there still are 40k+ weekly downloads for this version.

Eliminate incorrect space from enum string. See https://github.com/bpmn-io/bpmn-moddle/blob/main/resources/bpmn/xsd/BPMNDI.xsd#L82-L91.

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 3, 2026 •
edited
Loading

@hkleungai Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 74628,
  "author": "hkleungai",
  "headCommitOid": "91925c25a7c0e003048a8c2599cba844af5aa07a",
  "mergeBaseOid": "ba41421ed1c15200aab32957909fc2974cbd7022",
  "lastPushDate": "2026-03-03T17:58:48.000Z",
  "lastActivityDate": "2026-03-09T13:54:18.000Z",
  "mergeOfferDate": "2026-03-09T13:53:12.000Z",
  "mergeRequestDate": "2026-03-09T13:54:18.000Z",
  "mergeRequestUser": "hkleungai",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "bpmn-moddle",
      "kind": "edit",
      "files": [
        {
          "path": "types/bpmn-moddle/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/bpmn-moddle/bpmn-moddle-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/bpmn-moddle/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/bpmn-moddle/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/bpmn-moddle/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/bpmn-moddle/v9/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/bpmn-moddle/v9/bpmn-moddle-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/bpmn-moddle/v9/index.d.cts",
          "kind": "definition"
        },
        {
          "path": "types/bpmn-moddle/v9/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/bpmn-moddle/v9/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/bpmn-moddle/v9/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "RedMser",
      "date": "2026-03-09T13:52:29.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 3992688770,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the No Other Owners This DT module only has one owner, so we can't have someone verify the change. label Mar 3, 2026
@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Mar 3, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 3, 2026

🔔 @hkleungai — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@RedMser
Copy link
Copy Markdown

RedMser commented Mar 4, 2026 •
edited
Loading

Hi, thanks for working on this!

I looked into the PR's changes, and I don't believe they are enough to resolve #74540. As mentioned there, a breaking change of v10 is that you can no longer import the library with a default import.

I applied the PR's changes locally to my install, and my TS code still runs into this error:

// Module '"bpmn-moddle"' has no exported member 'BpmnModdle'.
// Did you mean to use 'import BpmnModdle from "bpmn-moddle"' instead?ts(2614)
import { BpmnModdle } from 'bpmn-moddle';

While I haven't looked too deeply into it, I assume we'd need to remove the declare namespace BPMNModdle and instead export all of the interfaces and types directly? And BPMNModdle becomes a named export instead of a default export.

@hkleungai hkleungai force-pushed the bpmn-moddle-update branch from 556958e to 91925c2 Compare March 4, 2026 17:19
@hkleungai
Copy link
Copy Markdown
Contributor Author

hkleungai commented Mar 4, 2026

Yep, I definitely missed the breaking change part....
Updated, hope I get this right this time.

RedMser
RedMser approved these changes Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown

@RedMser RedMser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I loaded the latest index.d.ts into our project and it works fine now.

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels Mar 9, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 9, 2026

@hkleungai: Everything looks good here. I am ready to merge this PR (at 91925c2) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board Mar 9, 2026
@hkleungai
Copy link
Copy Markdown
Contributor Author

hkleungai commented Mar 9, 2026

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Mar 9, 2026
@typescript-bot typescript-bot merged commit 685b18c into DefinitelyTyped:master Mar 9, 2026
4 checks passed
@hkleungai hkleungai deleted the bpmn-moddle-update branch March 9, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@RedMser RedMser RedMser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

No Other Owners This DT module only has one owner, so we can't have someone verify the change. Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hkleungai @typescript-bot @RedMser