[eslint-plugin-jsx-a11y] Use eslint package for types#73831
Conversation
Replaces the dependency on the removed `@types/eslint` package with the official `eslint` package.
|
@MysteryBlokHed Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 73831,
"author": "MysteryBlokHed",
"headCommitOid": "9beb14f776251e2de7763bea794c8c0141d761ce",
"mergeBaseOid": "1bd98ac5bc0736394b19b16dacd2e8626a170b3c",
"lastPushDate": "2025-10-04T05:38:28.000Z",
"lastActivityDate": "2025-10-04T10:29:01.000Z",
"mergeOfferDate": "2025-10-04T10:10:51.000Z",
"mergeRequestDate": "2025-10-04T10:29:01.000Z",
"mergeRequestUser": "eagerestwolf",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "eslint-plugin-jsx-a11y",
"kind": "edit",
"files": [
{
"path": "types/eslint-plugin-jsx-a11y/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"eagerestwolf",
"ljharb"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "eagerestwolf",
"date": "2025-10-04T10:10:11.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 3367926604,
"ciResult": "pass"
} |
|
🔔 @eagerestwolf @ljharb — please review this PR in the next few days. Be sure to explicitly select |
|
Ready to merge |
|
Note this change means people still using ESLint v8 (such as those with plugins and config packages which still support v8) cannot use these types anymore. I think it would have probably been best to stick with using |
|
In that case, let's revert it. |
Related discussion: #73747
Replaces the dependency on the removed
@types/eslintpackage with the officialeslintpackage.pnpm test <package to test>.If changing an existing definition:
package.json.