Skip to content

[eslint-plugin-jsx-a11y] Use eslint package for types#73831

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
MysteryBlokHed:eslint-plugin-jsx-a11y/use-eslint-package
Oct 4, 2025
Merged

[eslint-plugin-jsx-a11y] Use eslint package for types#73831
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
MysteryBlokHed:eslint-plugin-jsx-a11y/use-eslint-package

Conversation

@MysteryBlokHed
Copy link
Copy Markdown
Contributor

Related discussion: #73747

Replaces the dependency on the removed @types/eslint package with the official eslint package.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

Replaces the dependency on the removed `@types/eslint` package with the
official `eslint` package.
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Oct 4, 2025

@MysteryBlokHed Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 73831,
  "author": "MysteryBlokHed",
  "headCommitOid": "9beb14f776251e2de7763bea794c8c0141d761ce",
  "mergeBaseOid": "1bd98ac5bc0736394b19b16dacd2e8626a170b3c",
  "lastPushDate": "2025-10-04T05:38:28.000Z",
  "lastActivityDate": "2025-10-04T10:29:01.000Z",
  "mergeOfferDate": "2025-10-04T10:10:51.000Z",
  "mergeRequestDate": "2025-10-04T10:29:01.000Z",
  "mergeRequestUser": "eagerestwolf",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "eslint-plugin-jsx-a11y",
      "kind": "edit",
      "files": [
        {
          "path": "types/eslint-plugin-jsx-a11y/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "eagerestwolf",
        "ljharb"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "eagerestwolf",
      "date": "2025-10-04T10:10:11.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 3367926604,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Oct 4, 2025
@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Oct 4, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @eagerestwolf @ljharb — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 4, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board Oct 4, 2025
@eagerestwolf
Copy link
Copy Markdown

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Oct 4, 2025
@typescript-bot typescript-bot merged commit 34b8a72 into DefinitelyTyped:master Oct 4, 2025
4 checks passed
@MysteryBlokHed MysteryBlokHed deleted the eslint-plugin-jsx-a11y/use-eslint-package branch October 4, 2025 14:38
@G-Rath
Copy link
Copy Markdown
Contributor

G-Rath commented Nov 19, 2025

Note this change means people still using ESLint v8 (such as those with plugins and config packages which still support v8) cannot use these types anymore.

I think it would have probably been best to stick with using @types/eslint as assumingly they'll get deprecated at some point at which point they'll just become an alias for eslint

@ljharb
Copy link
Copy Markdown
Contributor

ljharb commented Nov 20, 2025

In that case, let's revert it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants