fix: mark @types/eslint as stub#73734
Conversation
|
@JounQin Thank you for submitting this PR! This is a live comment that I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 0 packages in this PR (and infra files)
Code ReviewsThere aren't any other owners of this package, so a DT maintainer will review it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 31 days — it is considered abandoned, and therefore closed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 73734,
"author": "JounQin",
"headCommitOid": "abe6b26ace7afbad264c9d3333d69806f4bd19d5",
"mergeBaseOid": "e9f232de193d1581236cc5231a129a50026a72de",
"lastPushDate": "2025-09-24T02:53:20.000Z",
"lastActivityDate": "2025-10-17T19:10:30.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical",
"isSafeInfrastructureEdit": false
}
],
"reviews": [
{
"type": "changereq",
"reviewer": "sheetalkamat",
"date": "2025-10-17T19:10:30.000Z"
}
],
"mainBotCommentID": 3326248377,
"ciResult": "pass"
} |
|
🔔 @JounQin — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
cc @sandersn |
|
For super critical packages, we often don't publish the stub as it might mean causing more breaks. Maybe things would be better if the stubs instead used a peer dep on eslint. |
|
Re-ping @«anyone?»: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @JounQin. (Ping @«anyone?».) |
sheetalkamat
left a comment
There was a problem hiding this comment.
This was left out intentionally as per #70735
|
@JounQin One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@JounQin I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Nov 16th (in a week) if the issues aren't addressed. |
|
@JounQin To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you! |
Please fill in this template.
pnpm test <package to test>.notNeededPackages.json.related #70735 and prettier/eslint-plugin-prettier#762 (comment)