Skip to content

fix: mark @types/eslint as stub#73734

Closed
JounQin wants to merge 1 commit intoDefinitelyTyped:masterfrom
JounQin:patch-1
Closed

fix: mark @types/eslint as stub#73734
JounQin wants to merge 1 commit intoDefinitelyTyped:masterfrom
JounQin:patch-1

Conversation

@JounQin
Copy link
Copy Markdown
Contributor

@JounQin JounQin commented Sep 24, 2025

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change.
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run pnpm test <package to test>.
  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

related #70735 and prettier/eslint-plugin-prettier#762 (comment)

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Sep 24, 2025

@JounQin Thank you for submitting this PR!

This is a live comment that I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

0 packages in this PR (and infra files)

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes that affect DT infrastructure (notNeededPackages.json)

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 73734,
  "author": "JounQin",
  "headCommitOid": "abe6b26ace7afbad264c9d3333d69806f4bd19d5",
  "mergeBaseOid": "e9f232de193d1581236cc5231a129a50026a72de",
  "lastPushDate": "2025-09-24T02:53:20.000Z",
  "lastActivityDate": "2025-10-17T19:10:30.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical",
      "isSafeInfrastructureEdit": false
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "sheetalkamat",
      "date": "2025-10-17T19:10:30.000Z"
    }
  ],
  "mainBotCommentID": 3326248377,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @JounQin — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Sep 24, 2025
@JounQin
Copy link
Copy Markdown
Contributor Author

JounQin commented Sep 24, 2025

cc @sandersn

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board Sep 24, 2025
@jakebailey
Copy link
Copy Markdown
Member

For super critical packages, we often don't publish the stub as it might mean causing more breaks.

Maybe things would be better if the stubs instead used a peer dep on eslint.

@typescript-bot
Copy link
Copy Markdown
Contributor

Re-ping @«anyone?»:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Oct 5, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @JounQin.

(Ping @«anyone?».)

Copy link
Copy Markdown
Contributor

@sheetalkamat sheetalkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was left out intentionally as per #70735

@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Oct 17, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@JounQin One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Needs Author Action in Pull Request Status Board Oct 17, 2025
@typescript-bot typescript-bot added the Abandoned This PR had no activity for a long time, and is considered abandoned label Nov 10, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@JounQin I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Nov 16th (in a week) if the issues aren't addressed.

@typescript-bot
Copy link
Copy Markdown
Contributor

@JounQin To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Abandoned This PR had no activity for a long time, and is considered abandoned Edits Infrastructure Revision needed This PR needs code changes before it can be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants