[diff] Add ESM entrypoint#69537
Conversation
|
@andrewbranch Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69537,
"author": "andrewbranch",
"headCommitOid": "4c9b00b5e7a47c70691a6f101ac07ee903aafc8f",
"mergeBaseOid": "ce432dd83521beac5e46b4e82cdc1d86d963518a",
"lastPushDate": "2024-05-06T18:17:53.000Z",
"lastActivityDate": "2024-05-06T18:58:26.000Z",
"mergeOfferDate": "2024-05-06T18:23:06.000Z",
"mergeRequestDate": "2024-05-06T18:58:26.000Z",
"mergeRequestUser": "andrewbranch",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "attw.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical",
"isSafeInfrastructureEdit": true
},
{
"name": "diff",
"kind": "edit",
"files": [
{
"path": "types/diff/diff-tests.mts",
"kind": "test"
},
{
"path": "types/diff/index.d.mts",
"kind": "definition"
},
{
"path": "types/diff/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/diff/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"vvakame",
"szdc",
"BendingBender",
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2024-05-06T18:22:28.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2096639421,
"ciResult": "pass"
} |
typescript-bot
added
the
Popular package
|
🔔 @vvakame @szdc @BendingBender @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select |
| @@ -0,0 +1 @@ | |||
| export * from "./index.js"; | |||
There was a problem hiding this comment.
index.mjs is actually a duplicated bundle, but re-exporting instead of duplicating types is the better tradeoff for now
| "import": "./index.d.mts", | ||
| "require": "./index.d.ts" | ||
| }, | ||
| "./package.json": "./package.json" |
There was a problem hiding this comment.
diff also exposes "./*", but I didn’t handle that for now since the types have never exposed individual files.
typescript-bot
added
Maintainer Approved
Self Merge
|
@andrewbranch: Everything looks good here. I am ready to merge this PR (at 4c9b00b) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@vvakame, @szdc, @BendingBender, @peterblazejewicz: you can do this too.) |
|
Ready to merge |
3 participants
Please fill in this template.
Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run
pnpm test <package to test>.Provide a URL to documentation or source code which provides context for the suggested changes: https://arethetypeswrong.github.io/?p=diff%405.2.0
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the
package.json.