Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 81.87% 81.87%
=======================================
Files 11 11
Lines 1754 1754
=======================================
Hits 1436 1436
Misses 318 318 ☔ View full report in Codecov by Sentry. |
MMathisLab
approved these changes
Feb 20, 2024
Contributor
|
@jeylau Could we also update the README? Currently it mentions:
|
Contributor
Author
|
Good catch @n-poulsen; fixed! |
n-poulsen
approved these changes
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locally tested with
python -m build .andpip installthe wheel.@n-poulsen, if we can get the tests to systematically pass, I can release a new version (or we just accept that the
deploystep may be done even if some tests have failed).